fix(ci): drop illegal timeout-minutes from scorecard caller (finish #65)#66
Merged
Conversation
PR #65 added the required caller permissions (which cleared the original startup_failure) but also copied `timeout-minutes: 15` from rsr-template-repo. That key is NOT permitted on a job that calls a reusable workflow via `uses:` — only name/uses/with/secrets/needs/if/permissions are allowed — so the run kept failing at startup (actionlint syntax-check confirms). Remove timeout-minutes; keep the permissions block and concurrency guard. NOTE: rsr-template-repo's scorecard.yml carries the same invalid timeout-minutes and needs the same fix upstream. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #65.
Problem
#65 added the required caller permissions (clearing the original
startup_failurefrom missingsecurity-events/id-token), but it also copiedtimeout-minutes: 15fromrsr-template-repo. That key is not permitted on a job that calls a reusable workflow viauses:— onlyname/uses/with/secrets/needs/if/permissionsare allowed — so the Scorecard run kept failing at startup.Confirmed with
actionlint:Fix
Remove
timeout-minutes. Keep the permissions block (the real fix) and the concurrency guard.actionlintnow passes clean.Upstream note
hyperpolymath/rsr-template-repo'sscorecard.ymlcarries the same invalidtimeout-minutesand needs the same fix — its own Scorecard run is likely failing too.🤖 Generated with Claude Code