Phase 1: optimization story — vetted wasm-opt pass list + verifier gate (#131)#148
Merged
Conversation
…verifier gate (Phase 1 / #131) Documents the Binaryen pass list that preserves L1-L10 (docs/optimization.adoc): optimize with external wasm-opt, use typed-wasm-verify as the invariant oracle (re-run post-opt; accept iff the typedwasm.* carriers survive intact). Per-carrier analysis + two hazards (custom-section stripping -> vacuous verification; function reindexing -> carriers point at wrong functions) + the vetted/excluded/safe split. - tests/optimization.rs: both hazards pinned in-repo; end-to-end wasm-opt -> tw-verify gate (graceful skip where wasm-opt is absent) - chore: add SPDX header to CHANGELOG.md (clears the governance SPDX advisory) cargo test --workspace --locked green; fmt + clippy clean; no new deps. Completes the 'document' arm of #131. Part of Phase 1 (#49). https://claude.ai/code/session_01Rq4da8i2uGnDUfanSB1Hx4
hyperpolymath
marked this pull request as ready for review
May 31, 2026 07:20
🔍 Hypatia Security ScanFindings: 86 issues detected
View findings[
{
"reason": "Action perpolymath/standards/.github/workflows/governance-reusable.yml@main\n needs attention",
"type": "unpinned_action",
"file": "governance.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in boj-build.yml",
"type": "missing_timeout_minutes",
"file": "boj-build.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in c5-regenerate.yml",
"type": "missing_timeout_minutes",
"file": "c5-regenerate.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in cargo-audit.yml",
"type": "missing_timeout_minutes",
"file": "cargo-audit.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in codeql.yml",
"type": "missing_timeout_minutes",
"file": "codeql.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in dogfood-gate.yml",
"type": "missing_timeout_minutes",
"file": "dogfood-gate.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in dogfood-gate.yml",
"type": "missing_timeout_minutes",
"file": "dogfood-gate.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in dogfood-gate.yml",
"type": "missing_timeout_minutes",
"file": "dogfood-gate.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in dogfood-gate.yml",
"type": "missing_timeout_minutes",
"file": "dogfood-gate.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in dogfood-gate.yml",
"type": "missing_timeout_minutes",
"file": "dogfood-gate.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
}
]Powered by Hypatia Neurosymbolic CI/CD Intelligence |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #131 (optimization story) — the deliverable's "document" arm — plus a cleanup.
#131 — optimization story
docs/optimization.adoc: optimize with externalwasm-opt(Binaryen), usetyped-wasm-verifyas the invariant oracle. The per-carrier analysis shows the L1–L10 invariants survive optimization iff thetypedwasm.*carriers survive — and names the two hazards:…with the vetted / excluded / safe pass split that avoids them, and a cleaner long-term alternative (optimize code-only, then attach carriers).
tests/optimization.rs(3 tests): pins both hazards in-repo (carrier presence vs vacuous acceptance;func_idxis load-bearing), plus an end-to-endwasm-opt → tw-verifygate that runs wherewasm-optis onPATHand skips gracefully otherwise (it's absent in this environment).Cleanup
Added the missing SPDX header to
CHANGELOG.md(clears the recurring governance / SessionStart advisory).Verification (Actions credit exhausted → local)
cargo test --workspace --lockedgreen — codegen 28 + verifier 80;cargo fmt --check+cargo clippy -D warningsclean; no new deps.The deliverable is "implement passes or document the pass list that preserves L1–L10" — the document arm is complete and its claims are test-pinned, so I'll close #131 on merge. Part of Phase 1 (#49).
https://claude.ai/code/session_01Rq4da8i2uGnDUfanSB1Hx4
Generated by Claude Code