Skip to content

Commit 5f2bb0c

Browse files
hyperpolymathclaude
andcommitted
STATE.a2ml: re-grade attempt — restore self-declared C; record full
audit-closure pass (8/10 items) Re-grade attempt for valence-shell after this session's audit-closure work. The CRG-AUDIT-2026-04-18 D demotion was based on three specific blockers, all now addressed: (a) .expect("TODO: handle error") sweep — CLOSED on source side (~512 sites cleared, estate-wide grep zero hits); CI green CONFIRMATION blocked by the active GitHub Actions billing issue (Jonathan-owned). Causal logic: with the only audit-cited failure cause cleared, CI should turn green when it can run. (b) Undeclared Coq admit — CLOSED (admitted=0 → 1 with full detail in commit dd03fd8). (c) README coverage 23% — CLOSED (19 missing READMEs added across batches 1-4; 24/24 originally-missing subtrees addressed; benches/ resolved-by-absence). Self-declared grade restored to C with the (a)-confirmation caveat explicit in [crg] notes. Audit-closure scoreboard recorded in same block: 8 of 10 items closed (1, 2, 3, 4, 5, 7, 9, 10c); 4 remain (6 verify-proofs CI, 8 contractile six-verb, 10a 47 author rewrite [needs Jonathan auth], 10b Echidna CI wiring). Other STATE updates: * [project-context] completion-percentage: 74 → 78 (modest bump reflecting docs + sweep + restructures done this session). * [recent-work] tasks-completed: 11 entries with commit citations (was 8); covers the docs hygiene + READMEs + Phase 4C archive + FIFO race fix added since the last STATE update. * [session-history]: 2026-04-19 line expanded with the full pass summary. * [crg] adds re-grade-attempted = "2026-04-19" and explicit "Promotion to B requires external dogfooding (6+ targets)" note for future-reviewer clarity. Reviewer may further demote on (a) if the CI-green confirmation is treated as load-bearing for the C grade; the in-source closure is done and documented. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 59b5f3b commit 5f2bb0c

1 file changed

Lines changed: 45 additions & 22 deletions

File tree

.machine_readable/6a2/STATE.a2ml

Lines changed: 45 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# SPDX-License-Identifier: PMPL-1.0-or-later
22
# STATE.a2ml — Project state checkpoint
3-
# Last updated: 2026-04-19 (CRG-AUDIT-2026-04-18 closure: items 1+2+4)
3+
# Last updated: 2026-04-19 (CRG-AUDIT-2026-04-18 closure pass: items 1+2+3+4+5+7+9+10c + FIFO race fix)
44

55
[metadata]
66
project = "valence-shell"
@@ -10,21 +10,24 @@ status = "active"
1010

1111
[project-context]
1212
name = "valence-shell"
13-
completion-percentage = 74
13+
completion-percentage = 78
1414
phase = "advanced-research-prototype"
1515

1616
[recent-work]
17-
session = "2026-04-19 CRG-AUDIT-2026-04-18 closure pass (items 1+2+4)"
18-
focus = "Close .expect(\"TODO\") anti-pattern, declare Coq admit honestly, populate [dogfooding-status]"
17+
session = "2026-04-19 CRG-AUDIT-2026-04-18 closure pass (8 of 10 items closed)"
18+
focus = "Close .expect(\"TODO\") anti-pattern, declare Coq admit honestly, populate [dogfooding-status], port docs/governance items, write 19 missing per-directory READMEs, fix FIFO-path race"
1919
tasks-completed = [
2020
".expect(\"TODO: handle error\") sweep CLOSED: ~512/~530 sites cleared across 17 files (8 batches + impl/rust-ffi/ deletion); commits 712e3a1, 962da88, f045ced, 6d4c211, c6b59b8, 1036832, d5f045d, f43cfb5, b5cc0cc",
2121
"9 production-code restructures: executable.rs:450 (if-let-cloned), functions.rs:320 + parser.rs:1797 (let-else), glob.rs:201 (documented expect for brace_depth invariant), external.rs:164,168-185 (match &redirect_setup pivot), commands.rs fg/bg (clone job.command early), parser.rs ~12 peek/while-let-Some(&c) sites (use bound value)",
22-
"impl/rust-ffi/ deleted as duplicate of ffi/rust/ (latter is canonical superset, matches CLAUDE.md ABI/FFI standard)",
23-
"ANCHOR.a2ml version 1.0.0 → 0.9.0 (Sonnet-era drift)",
24-
"alkahest-shell-transmuter/README.adoc author email placeholder → j.d.a.jewell@open.ac.uk",
25-
"ROADMAP.adoc populated from CLAUDE.md (was 22-line rsr-template stub) — v0.9.x stabilisation track, v0.10.x POSIX, v1.0.0 production gate, v2.0 Idris2 extraction path",
26-
"STATE.a2ml [coq-proof-status]: admitted = 0 → 1 (declare the pre-existing single_op_reversible OpRmdir admit honestly)",
27-
"STATE.a2ml [dogfooding-status]: section added with honest disclosure (no daily-driver use claimed)"
22+
"impl/rust-ffi/ deleted as duplicate of ffi/rust/ (latter is canonical superset, matches CLAUDE.md ABI/FFI standard); commit f43cfb5",
23+
"ANCHOR.a2ml version 1.0.0 → 0.9.0 (Sonnet-era drift); commit fc3313b",
24+
"alkahest-shell-transmuter/README.adoc author email placeholder → j.d.a.jewell@open.ac.uk; commit fc3313b",
25+
"ROADMAP.adoc populated from CLAUDE.md (was 22-line rsr-template stub) — v0.9.x stabilisation track, v0.10.x POSIX, v1.0.0 production gate, v2.0 Idris2 extraction path; commit fc3313b",
26+
"STATE.a2ml [coq-proof-status]: admitted = 0 → 1 (declare the pre-existing single_op_reversible OpRmdir admit honestly); commit 503b54e",
27+
"STATE.a2ml [dogfooding-status]: section added with honest disclosure (no daily-driver use claimed); commit 503b54e",
28+
"Phase 4C Lean-extraction archival banners on PHASE4C_LEAN_EXTRACTION.md + LEAN_EXTRACTION_BUILD_GUIDE.md (their endpoint lean_ffi.rs was removed in 5802dc9 long before the audits); commit dd35630",
29+
"19 per-directory READMEs added across 4 batches: impl/, impl/rust-cli/{src,tests}/, impl/{elixir,ocaml,mcp}/, ffi/{rust,zig}/, src/abi/, proofs/{coq,lean4,agda,isabelle,mizar,z3}/, docs/, scripts/, examples/, hooks/ (benches/ resolved-by-absence). Coverage move: 5/22 (~23%) → 24/24 originally-missing addressed. Commits 9ecad26, cb0f0b8, 03705b5, 2d2723e",
30+
"FIFO-path race fix in process_sub.rs: appended uuid::Uuid::new_v4().simple() to /tmp/vsh-fifo-<pid>-<counter>-<uuid>; transient process_sub::tests::test_fifo_path_unique flake (collision when two ShellState instances share a pid in parallel cargo tests) eliminated. 10/10 stress runs stable; full suite 703/0/14 unchanged. Production fix too — same collision could affect multi-container vsh deployments. Commit 2efd506"
2831
]
2932

3033
[coq-proof-status]
@@ -55,28 +58,48 @@ note = "Promotion to C-grade dogfooding evidence requires real daily-driver use
5558
[session-history]
5659
# 2026-04-04: CRG-C blitz — 59 new tests, benchmarks, E2E, Zig, Elixir
5760
# 2026-04-12: P0 sweep — Coq layer: 1 justified Axiom (was 3 Axiom + structural bugs); Admitted not yet declared
58-
# 2026-04-19: .expect("TODO") anti-pattern sweep CLOSED (~512 sites); admitted=0 claim corrected to admitted=1; [dogfooding-status] section added; impl/rust-ffi/ deleted as duplicate
61+
# 2026-04-19: .expect("TODO") anti-pattern sweep CLOSED (~512 sites); admitted=0 admitted=1 declared; [dogfooding-status] section added; impl/rust-ffi/ deleted as duplicate; 19 per-directory READMEs landed (coverage 23% → all originally-missing addressed); Phase 4C Lean-extraction docs archived; FIFO-path race fixed; ROADMAP populated; ANCHOR + alkahest email drift fixed
5962

6063
[crg]
6164
grade = "C"
6265
achieved = "2026-04-04"
66+
re-grade-attempted = "2026-04-19"
6367
audit = "docs/governance/CRG-AUDIT-2026-04-18.adoc"
6468
notes = """
65-
Audit-2026-04-18 demoted self-declared C → D on three blockers:
69+
Audit-2026-04-18 demoted self-declared C → D on three specific blockers:
6670
(a) 404 .expect(\"TODO: handle error\") sites making CI red,
6771
(b) undeclared single_op_reversible admit (admitted=0 claim was wrong),
6872
(c) per-directory README coverage 23% (5/22 subtrees).
6973

70-
Status as of 2026-04-19:
71-
(a) CLOSED — ~512 sites cleared in commits 712e3a1..b5cc0cc;
72-
estate-wide grep returns zero source-code hits.
74+
Status as of 2026-04-19 (post-closure-pass):
75+
(a) CLOSED on the source side — ~512 sites cleared in commits
76+
712e3a1..b5cc0cc; estate-wide grep returns zero source-code hits.
77+
CI green CONFIRMATION blocked: the 7 post-sweep rust-cli.yml
78+
runs are stuck status=queued due to the active GitHub Actions
79+
billing block (Jonathan-owned; tracked in
80+
~/Desktop/YOUR-ACTIONS-todo.md). Causal logic: with the
81+
anti-pattern (the only audit-cited cause of the 30/30 failures)
82+
cleared, CI should turn green when it runs.
7383
(b) CLOSED — admitted=0 corrected to admitted=1 with full
74-
admitted-detail this commit.
75-
(c) OPEN — README coverage still 23%.
84+
admitted-detail; commit 503b54e.
85+
(c) CLOSED — 19 missing READMEs added across batches 1-4 (commits
86+
9ecad26, cb0f0b8, 03705b5, 2d2723e); the audit's 5/22 baseline
87+
is now effectively 24/24 of originally-missing subtrees
88+
(benches/ resolved-by-absence — directory does not exist).
7689

77-
Plus open from audit: validation.yml verify-proofs gated, contractile
78-
six-verb completion, audit-2026-04-04 residuals (47 spoofed authors,
79-
Echidna CI wiring, dead code). Self-declared grade kept at C pending
80-
README sweep and verify-proofs enablement; reviewer may demote to D
81-
per audit until (c) closes.
90+
All three audit demotion reasons addressed. Self-declared grade
91+
restored to C with the (a)-CI-confirmation caveat above.
92+
93+
Audit closure scoreboard (8 of 10 closed in the 2026-04-19 pass):
94+
✅ Item 1: .expect sweep ✅ Item 7: ANCHOR version
95+
✅ Item 2: Coq admit declared ✅ Item 9: alkahest email
96+
✅ Item 3: README coverage ✅ Item 10c: dead code (already done)
97+
✅ Item 4: [dogfooding-status] ⏳ Item 6: verify-proofs CI gate
98+
✅ Item 5: ROADMAP populated ⏳ Item 8: contractile six-verb
99+
⏳ Item 10a: 47 spoofed authors (auth-gated)
100+
⏳ Item 10b: Echidna CI wiring
101+
102+
Promotion to B requires external dogfooding evidence (6+ diverse
103+
external targets, issues fed back) which is fundamentally outside
104+
this session's reach.
82105
"""

0 commit comments

Comments
 (0)