Skip to content

Commit dd03fd8

Browse files
hyperpolymathclaude
andcommitted
STATE.a2ml: declare Coq admit honestly, add [dogfooding-status]
Closes audit items 2 + 4 from CRG-AUDIT-2026-04-18: Item 2 — Coq admit declaration: The prior `[coq-proof-status] admitted = 0` claim was contradicted by `proofs/coq/filesystem_composition.v:199` which contains an active `simpl in *. admit.` inside the `single_op_reversible` OpRmdir branch. The in-source comment (lines 195-198) acknowledged the model gap but the STATE field misreported it. Updated: admitted = 1 # was 0 admitted-detail = "single_op_reversible OpRmdir branch: mkdir restores with default_perms, but the original directory may have had different permissions, so mkdir(rmdir(fs)) ≠ fs in general. Known limitation of the Filesystem = Path -> option FSNode model." proof-debt-open = [3] # was [] The proof itself stays as `admit.` for now (closing it requires interactive Coq work and either a model change to preserve original node data in the undo stack, or an explicit weaker invariant). Item 4 — [dogfooding-status] section added: Honest disclosure: valence-shell v0.9.0 is explicitly NOT a daily-driver bash/zsh replacement (per CLAUDE.md). The author does not run vsh as their interactive shell, no systemd units invoke it, no estate consumers shell out to it. Section is present for v2.0 schema completeness but does NOT claim C-grade dogfooding evidence. Concrete fields recorded: test-verification-2026-04-19 (703/0/14 + 24/0/0) examples-on-disk (present, not CI-exercised) external-consumers (none known) note (sectional presence ≠ C evidence) [recent-work] + [session-history] + [crg] notes also updated to reflect the .expect("TODO") sweep closure (commits ee73b1c..c7c0a98). [crg] grade kept at self-declared C with explicit acknowledgement that the audit demoted to D; reviewer may demote per audit until the README coverage gap (23%) closes. Item 6 (enable validation.yml verify-proofs job) deferred — needs CI iteration to verify Lean install on GitHub runner, separate session. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent c7c0a98 commit dd03fd8

1 file changed

Lines changed: 54 additions & 18 deletions

File tree

.machine_readable/6a2/STATE.a2ml

Lines changed: 54 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
# SPDX-License-Identifier: PMPL-1.0-or-later
22
# STATE.a2ml — Project state checkpoint
3-
# Last updated: 2026-04-12 (P0 believe_me sweep + Coq proof debt closure)
3+
# Last updated: 2026-04-19 (CRG-AUDIT-2026-04-18 closure: items 1+2+4)
44

55
[metadata]
66
project = "valence-shell"
77
version = "0.9.0"
8-
last-updated = "2026-04-12"
8+
last-updated = "2026-04-19"
99
status = "active"
1010

1111
[project-context]
@@ -14,33 +14,69 @@ completion-percentage = 74
1414
phase = "advanced-research-prototype"
1515

1616
[recent-work]
17-
session = "2026-04-12 P0 believe_me sweep / Coq proof debt closure"
18-
focus = "Close estate-wide proof debt — valence-shell Coq layer"
17+
session = "2026-04-19 CRG-AUDIT-2026-04-18 closure pass (items 1+2+4)"
18+
focus = "Close .expect(\"TODO\") anti-pattern, declare Coq admit honestly, populate [dogfooding-status]"
1919
tasks-completed = [
20-
"posix_errors.v: full rewrite — 5/6 decision procedures proved constructively (was Axiom)",
21-
"posix_errors.v: fixed structural bug — negb(sumbool) type error in all safe_* defs",
22-
"posix_errors.v: fixed forward-reference bug — axioms were declared after use",
23-
"filesystem_model.v: fixed path_prefix return type (bool, not Prop) in is_empty_dir",
24-
"filesystem_composition.v: proved well_formed_ancestor_exists (was Axiom, debt #1)",
25-
"filesystem_composition.v: proved mkdir_preserves_well_formed (was Axiom, debt #2)",
26-
"filesystem_composition.v: added 6 helper lemmas for path prefix / length reasoning",
27-
"_CoqProject: -Q → -R (recursive logical path mapping, correct for subdir imports)",
28-
"proofs/coq/.gitignore: added to exclude *.vo/*.vos/*.vok/*.glob/Makefile artifacts",
29-
"Commit 1ef841c pushed to GitHub"
20+
".expect(\"TODO: handle error\") sweep CLOSED: ~512/~530 sites cleared across 17 files (8 batches + impl/rust-ffi/ deletion); commits 712e3a1, 962da88, f045ced, 6d4c211, c6b59b8, 1036832, d5f045d, f43cfb5, b5cc0cc",
21+
"9 production-code restructures: executable.rs:450 (if-let-cloned), functions.rs:320 + parser.rs:1797 (let-else), glob.rs:201 (documented expect for brace_depth invariant), external.rs:164,168-185 (match &redirect_setup pivot), commands.rs fg/bg (clone job.command early), parser.rs ~12 peek/while-let-Some(&c) sites (use bound value)",
22+
"impl/rust-ffi/ deleted as duplicate of ffi/rust/ (latter is canonical superset, matches CLAUDE.md ABI/FFI standard)",
23+
"ANCHOR.a2ml version 1.0.0 → 0.9.0 (Sonnet-era drift)",
24+
"alkahest-shell-transmuter/README.adoc author email placeholder → j.d.a.jewell@open.ac.uk",
25+
"ROADMAP.adoc populated from CLAUDE.md (was 22-line rsr-template stub) — v0.9.x stabilisation track, v0.10.x POSIX, v1.0.0 production gate, v2.0 Idris2 extraction path",
26+
"STATE.a2ml [coq-proof-status]: admitted = 0 → 1 (declare the pre-existing single_op_reversible OpRmdir admit honestly)",
27+
"STATE.a2ml [dogfooding-status]: section added with honest disclosure (no daily-driver use claimed)"
3028
]
3129

3230
[coq-proof-status]
33-
admitted = 0
31+
admitted = 1
3432
axioms-justified = 1
33+
admitted-detail = "single_op_reversible OpRmdir branch (proofs/coq/filesystem_composition.v:199): mkdir restores with default_perms, but the original directory may have had different permissions, so mkdir(rmdir(fs)) ≠ fs in general. Full reversibility requires the undo stack to preserve original node data. Known limitation of the Filesystem = Path -> option FSNode model. Pre-existing model gap, flagged in CRG-AUDIT-2026-04-18; the in-source comment at line 195-198 acknowledges it. Declaring honestly here corrects the prior `admitted = 0` claim."
3534
axiom-detail = "is_empty_dir_dec: Filesystem = Path -> option FSNode is infinite-domain; universal quantification over all paths is not constructively decidable. Migration: switch to FMaps.t FSNode."
3635
proof-debt-items-closed = [1, 2]
37-
proof-debt-open = []
36+
proof-debt-open = [3]
37+
38+
[dogfooding-status]
39+
# Section present per CRG v2.0 schema. Honest disclosure follows.
40+
#
41+
# valence-shell v0.9.0 is explicitly NOT a daily-driver bash/zsh
42+
# replacement (per CLAUDE.md "What Does NOT Work"). The author does
43+
# not run vsh as their interactive shell, no systemd units invoke it,
44+
# and no cross-project consumers shell out to vsh. Continuous
45+
# home-context use cannot be honestly claimed at this stage.
46+
#
47+
# Concrete development-time use does happen via `cargo run` (REPL
48+
# smoke), `cargo test` (correctness), and the in-tree `examples/`.
49+
# These are development verification, not user-facing dogfooding.
50+
test-verification-2026-04-19 = "cargo test (impl/rust-cli): 703 passed / 0 failed / 14 ignored, after the .expect(\"TODO\") sweep closure (commit b5cc0cc). cargo test (ffi/rust): 24 passed / 0 failed / 0 ignored."
51+
examples-on-disk = "examples/ directory present; not exercised in CI yet."
52+
external-consumers = "none known; valence-shell is not yet imported, scripted-against, or shelled-out-to by any other repo in the estate."
53+
note = "Promotion to C-grade dogfooding evidence requires real daily-driver use or cross-project shell-out. Sectional presence here is for schema completeness, not C-grade evidence."
3854

3955
[session-history]
4056
# 2026-04-04: CRG-C blitz — 59 new tests, benchmarks, E2E, Zig, Elixir
41-
# 2026-04-12: P0 sweep — Coq layer: 0 Admitted, 1 justified Axiom (was 3 Axiom + structural bugs)
57+
# 2026-04-12: P0 sweep — Coq layer: 1 justified Axiom (was 3 Axiom + structural bugs); Admitted not yet declared
58+
# 2026-04-19: .expect("TODO") anti-pattern sweep CLOSED (~512 sites); admitted=0 claim corrected to admitted=1; [dogfooding-status] section added; impl/rust-ffi/ deleted as duplicate
4259

4360
[crg]
4461
grade = "C"
4562
achieved = "2026-04-04"
46-
notes = "Coq proof completeness improved: was 3 Axiom (2 deferred + 1 justified), now 0 Admitted + 1 justified"
63+
audit = "docs/governance/CRG-AUDIT-2026-04-18.adoc"
64+
notes = """
65+
Audit-2026-04-18 demoted self-declared C → D on three blockers:
66+
(a) 404 .expect(\"TODO: handle error\") sites making CI red,
67+
(b) undeclared single_op_reversible admit (admitted=0 claim was wrong),
68+
(c) per-directory README coverage 23% (5/22 subtrees).
69+
70+
Status as of 2026-04-19:
71+
(a) CLOSED — ~512 sites cleared in commits 712e3a1..b5cc0cc;
72+
estate-wide grep returns zero source-code hits.
73+
(b) CLOSED — admitted=0 corrected to admitted=1 with full
74+
admitted-detail this commit.
75+
(c) OPEN — README coverage still 23%.
76+
77+
Plus open from audit: validation.yml verify-proofs gated, contractile
78+
six-verb completion, audit-2026-04-04 residuals (47 spoofed authors,
79+
Echidna CI wiring, dead code). Self-declared grade kept at C pending
80+
README sweep and verify-proofs enablement; reviewer may demote to D
81+
per audit until (c) closes.
82+
"""

0 commit comments

Comments
 (0)