fix(clippy): clear 86 errors under -D warnings across impl/rust-cli/ (#74)

* fix(clippy): clear 86 errors under -D warnings across impl/rust-cli/

Combined auto-fix (`cargo clippy --fix`) for 60 mechanical lints +
manual fixes for the remaining 26 across 34 files.

Manual categories handled:
- `&PathBuf` → `&Path` (process_sub.rs ×2)
- `assert!(true)`, `assert!(len() >= 0)` removed (parser.rs, confirmation.rs, e2e_script_execution.rs)
- `manual_strip` → `strip_prefix` (functions.rs, state.rs, parser.rs)
- `format!` collapsed into outer `print!`/`println!` (pager.rs, commands.rs)
- `impl Default for RedirectSetup`
- doc_lazy_continuation: orphan doc block removed; new doc with blank line before
- empty_line_after_doc_comments: stray doc-comment without item removed
- unused_unsafe block removed from libc::WIFSTOPPED call
- needless_range_loop on Token slice → iterator + take/skip
- unused_doc_comments on macro invocations (proptest!) → plain `//` comments

Allow-listed (lint suggestion would change semantics or require
unrelated refactor; documented at each site):
- needless_range_loop on 2-D matrix init (correction.rs ×2)
- if_same_then_else on shell-operator branches (highlighter.rs)
- private_interfaces + dead_code on `expand_quoted_word_with_state`
- unused_assignments inside push_word! macro (parser.rs)
- should_implement_trait on TrapSignal::from_str (custom Option return)
- join_absolute_paths in sandbox-escape test (intentional)
- dead_code on test fixture helpers (populated_sandbox, dir_path, any_name, word)

Verification: `cargo clippy --all-targets --all-features -- -D warnings`
exits clean; `cargo test --release` reports 757 passed / 0 failed.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(fmt): apply cargo fmt to clear --check drift from PR #73

PR #73's fmt sweep agent ran an older rustfmt; CI's stable rustfmt
sees 8 files needing reformat (mostly merged-multiline-args + trailing-
whitespace + match-arm-wrap). Apply the corrections.

Verified: `cargo fmt --check` clean, `cargo clippy -D warnings` clean.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: hyperpolymath

impl/rust-cli/benches/performance_benchmarks.rs

@@ -16,9 +16,8 @@
 
 use criterion::{black_box, criterion_group, criterion_main, BenchmarkId, Criterion, Throughput};
 use std::fs;
-use std::io::Write;
 use tempfile::TempDir;
-use vsh::commands::{mkdir, redo, rm, touch, undo};
+use vsh::commands::{mkdir, redo, undo};
 use vsh::glob::expand_glob;
 use vsh::state::ShellState;
 

impl/rust-cli/src/arith.rs

@@ -665,15 +665,15 @@ pub fn eval_arith(expr: &ArithExpr, state: &ShellState) -> Result<i64> {
                 ArithOp::BitOr => Ok(lval | rval),
                 ArithOp::BitXor => Ok(lval ^ rval),
                 ArithOp::ShiftLeft => {
-                    if rval < 0 || rval >= 64 {
+                    if !(0..64).contains(&rval) {
                         Err(anyhow!("Shift count out of range: {}", rval))
                     } else {
                         lval.checked_shl(rval as u32)
                             .ok_or_else(|| anyhow!("Arithmetic overflow: {} << {}", lval, rval))
                     }
                 }
                 ArithOp::ShiftRight => {
-                    if rval < 0 || rval >= 64 {
+                    if !(0..64).contains(&rval) {
                         Err(anyhow!("Shift count out of range: {}", rval))
                     } else {
                         lval.checked_shr(rval as u32)

impl/rust-cli/src/audit_log.rs

@@ -15,7 +15,7 @@ use chrono::{DateTime, Utc};
 use serde::{Deserialize, Serialize};
 use std::fs::OpenOptions;
 use std::io::Write;
-use std::path::{Path, PathBuf};
+use std::path::PathBuf;
 use uuid::Uuid;
 
 use crate::state::Operation;

impl/rust-cli/src/commands.rs

@@ -1677,7 +1677,7 @@ pub fn show_graph(state: &ShellState) -> Result<()> {
                 .unwrap_or_else(|| format!("[non-reversible: {}]", op.path));
             print!("{}", inverse_str.bright_yellow());
         }
-        print!(" → [initial]\n");
+        println!(" → [initial]");
     }
 
     Ok(())
@@ -1797,7 +1797,7 @@ pub fn fg(state: &mut ShellState, job_spec: Option<&str>) -> Result<()> {
         }
 
         // Update job state based on wait result
-        if unsafe { libc::WIFSTOPPED(status) } {
+        if libc::WIFSTOPPED(status) {
             state.jobs.update_job_state(pgid, JobState::Stopped);
             println!(
                 "\n[{}]+  Stopped              {}",
@@ -2187,7 +2187,7 @@ pub fn explain_command(cmd: &crate::parser::Command, state: &ShellState) -> Resu
             let expanded = crate::parser::expand_variables(path, state);
             let resolved = state.resolve_path(&expanded);
             let parent = resolved.parent();
-            let parent_exists = parent.map_or(false, |p| p.exists());
+            let parent_exists = parent.is_some_and(|p| p.exists());
             let path_free = !resolved.exists();
             println!(
                 "    {} Parent exists:       {}",
@@ -2222,7 +2222,8 @@ pub fn explain_command(cmd: &crate::parser::Command, state: &ShellState) -> Resu
                 resolved.display()
             );
         }
-        crate::parser::Command::Chmod { path, .. } | crate::parser::Command::Chown { path, .. } => {
+        crate::parser::Command::Chmod { path: _, .. }
+        | crate::parser::Command::Chown { path: _, .. } => {
             // Outer arm guarantees we are in {Chmod, Chown}; the inner match
             // exists only to extract the `path` field uniformly. Any other
             // variant here is a structural bug, surfaced as typed error.
@@ -2577,15 +2578,12 @@ pub fn replay(state: &ShellState, start: usize, end: usize) -> Result<()> {
             op.path,
             format!("[op:{}]", &op.id.to_string()[..8]).bright_black()
         );
-        println!(
-            "    State: fs{} ──▶ fs{}",
-            if idx == 0 {
-                "₀".to_string()
-            } else {
-                format!("_{}", idx)
-            },
-            format!("_{}", idx + 1)
-        );
+        let from_state = if idx == 0 {
+            "₀".to_string()
+        } else {
+            format!("_{}", idx)
+        };
+        println!("    State: fs{} ──▶ fs_{}", from_state, idx + 1);
         println!(
             "    Proof: {} {}",
             proof.theorem.bright_cyan(),

impl/rust-cli/src/commands/secure_deletion.rs

@@ -434,7 +434,7 @@ pub fn obliterate_dir(
 #[cfg(test)]
 mod tests {
     use super::*;
-    use std::path::PathBuf;
+
     use tempfile::TempDir;
 
     #[test]

impl/rust-cli/src/confirmation.rs

@@ -3,7 +3,7 @@
 //!
 //! SAFETY CRITICAL: Prevents accidental data destruction
 
-use anyhow::{bail, Result};
+use anyhow::Result;
 use colored::Colorize;
 use std::io::{self, Write};
 
@@ -337,7 +337,6 @@ mod tests {
 
     #[test]
     fn test_count_files() {
-        let count = count_files_in_tree("/tmp").unwrap_or(0);
-        assert!(count >= 0);
+        let _ = count_files_in_tree("/tmp").unwrap_or(0);
     }
 }

impl/rust-cli/src/correction.rs

@@ -6,7 +6,6 @@
 
 use std::env;
 use std::fs;
-use std::path::PathBuf;
 
 /// Calculate Levenshtein distance between two strings
 ///
@@ -36,9 +35,11 @@ pub fn levenshtein_distance(a: &str, b: &str) -> usize {
     let mut matrix = vec![vec![0; len_b + 1]; len_a + 1];
 
     // Initialize first row and column
+    #[allow(clippy::needless_range_loop)]
     for i in 0..=len_a {
         matrix[i][0] = i;
     }
+    #[allow(clippy::needless_range_loop)]
     for j in 0..=len_b {
         matrix[0][j] = j;
     }

impl/rust-cli/src/echidna_integration.rs

@@ -24,8 +24,6 @@
 //!
 //! Author: Jonathan D.A. Jewell
 
-use std::collections::HashMap;
-
 // =========================================================================
 // Core types
 // =========================================================================
@@ -355,7 +353,7 @@ mod tests {
         let reversibility = registry.by_category(PropertyCategory::Reversibility);
         assert!(reversibility.len() >= 5);
         let security = registry.by_category(PropertyCategory::Security);
-        assert!(security.len() >= 1);
+        assert!(!security.is_empty());
     }
 
     #[test]

impl/rust-cli/src/enhanced_repl.rs

@@ -12,9 +12,9 @@ use anyhow::Result;
 use nu_ansi_term::{Color, Style};
 use reedline::{
     default_emacs_keybindings, ColumnarMenu, Completer, DefaultHinter, DefaultValidator, Emacs,
-    FileBackedHistory, HistoryItem, KeyCode, KeyModifiers, MenuBuilder, Prompt, PromptEditMode,
+    FileBackedHistory, KeyCode, KeyModifiers, MenuBuilder, Prompt, PromptEditMode,
     PromptHistorySearch, PromptHistorySearchStatus, Reedline, ReedlineEvent, ReedlineMenu, Signal,
-    Span, StyledText, Suggestion,
+    Span, Suggestion,
 };
 use std::borrow::Cow;
 use std::path::PathBuf;
@@ -180,24 +180,25 @@ fn complete_path(prefix: &str, pos: usize) -> Vec<Suggestion> {
 struct VshPrompt {
     txn_name: Option<String>,
     undo_count: usize,
+    #[allow(dead_code)]
     cwd: String,
     continuation: bool,
 }
 
 impl Prompt for VshPrompt {
-    fn render_prompt_left(&self) -> Cow<str> {
+    fn render_prompt_left(&self) -> Cow<'_, str> {
         Cow::Borrowed("")
     }
 
-    fn render_prompt_right(&self) -> Cow<str> {
+    fn render_prompt_right(&self) -> Cow<'_, str> {
         if let Some(ref txn) = self.txn_name {
             Cow::Owned(format!("[txn:{}]", txn))
         } else {
             Cow::Borrowed("")
         }
     }
 
-    fn render_prompt_indicator(&self, _edit_mode: PromptEditMode) -> Cow<str> {
+    fn render_prompt_indicator(&self, _edit_mode: PromptEditMode) -> Cow<'_, str> {
         if self.continuation {
             return Cow::Owned(Color::Yellow.paint("...> ").to_string());
         }
@@ -217,14 +218,14 @@ impl Prompt for VshPrompt {
         Cow::Owned(format!("{}{}", undo_indicator, txn_indicator))
     }
 
-    fn render_prompt_multiline_indicator(&self) -> Cow<str> {
+    fn render_prompt_multiline_indicator(&self) -> Cow<'_, str> {
         Cow::Borrowed("...> ")
     }
 
     fn render_prompt_history_search_indicator(
         &self,
         history_search: PromptHistorySearch,
-    ) -> Cow<str> {
+    ) -> Cow<'_, str> {
         let prefix = match history_search.status {
             PromptHistorySearchStatus::Passing => "",
             PromptHistorySearchStatus::Failing => "failing ",

impl/rust-cli/src/executable.rs

@@ -853,9 +853,8 @@ impl ExecutableCommand for Command {
 
             Command::Unset { name } => {
                 let expanded_name = crate::parser::expand_variables(name, state);
-                if expanded_name.starts_with("-f ") {
+                if let Some(func_name) = expanded_name.strip_prefix("-f ") {
                     // unset -f: remove a function
-                    let func_name = &expanded_name[3..];
                     if !state.functions.unset(func_name) {
                         eprintln!("unset: {}: not a function", func_name);
                     }
@@ -1160,7 +1159,7 @@ impl ExecutableCommand for Command {
                     for sig_name in signals {
                         let expanded = crate::parser::expand_variables(sig_name, state);
                         if let Some(sig) = TrapSignal::from_str(&expanded) {
-                            state.traps.set(sig, &action);
+                            state.traps.set(sig, action);
                         } else {
                             eprintln!("trap: {}: invalid signal specification", expanded);
                         }
@@ -1599,12 +1598,12 @@ fn case_pattern_matches(word: &str, pattern: &str) -> bool {
 
 /// Simple glob pattern matching for case statements
 fn glob_match(pattern: &str, text: &str) -> bool {
-    let mut p = pattern.chars().peekable();
-    let mut t = text.chars().peekable();
+    let _p = pattern.chars().peekable();
+    let _t = text.chars().peekable();
 
     glob_match_inner(
-        &mut pattern.chars().collect::<Vec<_>>(),
-        &mut text.chars().collect::<Vec<_>>(),
+        &pattern.chars().collect::<Vec<_>>(),
+        &text.chars().collect::<Vec<_>>(),
         0,
         0,
     )