Commit ca9fe50
fix(ci): repair two silently-rotted crates and close the CI coverage gaps
vcl-ut has FIVE cargo workspace roots. CI covered three of them, and the
two it missed had stopped compiling without anyone noticing.
WHAT ROTTED
`ast::Statement` gained the S1 consonance field `verb` (Select / Inspect /
Verify / Assert / Declare / Retract / Merge / Split / Normalise) — the
consonance turn itself. Two downstream crates were never updated:
src/interface/attest E0063: missing field `verb`
src/interface/recompute-wasm E0063: missing field `verb`
In both cases only the in-file `#[cfg(test)]` module was stale; the
libraries still built. That is why nothing downstream complained — 12
tests had simply stopped running, in the crates carrying the attestation
and recompute boundaries.
Fixed by supplying `verb: Verb::Select` at both sites. Both constructions
are the bare `SELECT * FROM STORE "s"` case and both already used the full
eight-modality `OctadSchema`, so the octad was already correct there; only
the verb was missing.
attest 9 tests, now green
recompute-wasm 3 tests, now green
Their Cargo.lock files had also drifted (recompute-wasm's recorded only the
two in-repo path crates and no external deps at all — it had not been
resolved since its manifest grew dependencies). Regenerated and committed.
WHY IT ROTTED — coverage map, measured 2026-07-21
/ e2e.yml PARTIAL (see below)
/src/interface/parse parse-gate.yml full
/src/interface/echidna-client backend-matrix.yml needs echidna sibling
/src/interface/attest NOTHING
/src/interface/recompute-wasm NOTHING
New satellite-crates-gate.yml gates the last two: clippy `-D warnings`
plus tests, over a matrix. Both were verified to pass `-D warnings` cleanly
before the gate was added, so this is a real gate that is green, not an
aspirational one. It mirrors parse-gate.yml's deliberate use of preinstalled
rustup over a third-party toolchain action.
`--locked` is deliberately omitted there for now, and the reason is recorded
in the workflow: the lockfiles are freshly regenerated after a long ungated
drift. It should be restored once a Dependabot cycle has run against them.
ALSO FIXED IN e2e.yml
1. The root job ran `--test property_test` + `--test integration_test` only:
69 of the root workspace's 102 tests. Every test in tests/e2e_test.rs (20)
and tests/fuzz_test.rs (13) was skipped. Now `cargo test --workspace
--all-targets --locked`, verified locally at 102 passed / 0 failed.
2. Removed both "Provide echidna sibling" steps, which cloned a whole
repository on every run for nothing. `src/interface` — the member that
carries the external `echidna-core` path-dep — is deliberately not a root
workspace member, so neither the root tests nor tests/e2e.sh ever resolve
it. Verified with no sibling present: 102 tests pass, e2e.sh reports 19/19.
echidna-client remains gated by backend-matrix.yml, which does need it.
CORRECTION TO AN EARLIER FINDING
An earlier read of this repository recorded "0 unit tests; root cargo test is
a fake gate". That was wrong, and was an artefact of truncating the log to its
last lines. The root crate is a re-export facade over fmt + lint, so per-crate
UNIT counts are legitimately zero and the entire surface lives in tests/.
The README's `tests-102 pass` badge is exact. Recorded in the e2e.yml header
so the same misreading is not repeated.
Verification:
reuse lint -> compliant, 459/459
23 workflows -> 0 malformed
cargo test --workspace --locked -> 102 passed
cargo test (parse) -> 36 passed
cargo test (attest) -> 9 passed
cargo test (recompute-wasm) -> 3 passed
bash tests/e2e.sh -> 19/19, no echidna sibling
150 tests total
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>1 parent 3ba8988 commit ca9fe50
6 files changed
Lines changed: 256 additions & 11 deletions
File tree
- .github/workflows
- src/interface
- attest
- src
- recompute-wasm
- src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
2 | 28 | | |
3 | 29 | | |
4 | 30 | | |
| |||
15 | 41 | | |
16 | 42 | | |
17 | 43 | | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | 44 | | |
22 | 45 | | |
23 | 46 | | |
24 | | - | |
| 47 | + | |
25 | 48 | | |
26 | 49 | | |
27 | 50 | | |
28 | 51 | | |
29 | 52 | | |
30 | 53 | | |
31 | 54 | | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
39 | 60 | | |
40 | 61 | | |
41 | 62 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
226 | 226 | | |
227 | 227 | | |
228 | 228 | | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
229 | 233 | | |
230 | 234 | | |
231 | 235 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
181 | 181 | | |
182 | 182 | | |
183 | 183 | | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
184 | 187 | | |
185 | 188 | | |
186 | 189 | | |
| |||
0 commit comments