fix(ci): green the three required gates + redirect stale stance doc#59
Merged
Conversation
- vclt-gate bin: replace the panicking .expect() in parse_vql_type with a match returning Err on the (impossible) empty-object case, and add #![deny(clippy::unwrap_used, clippy::expect_used)] so the bin meets the Aspect/SPARK gate's no-panic posture (the lib already carries it). #49 - echidna-client: declare an own [workspace] so it is a standalone root (its transitive echidna-core path-dep breaks the default standalone build); Backend-Matrix now runs it via --manifest-path instead of `-p`, which could not select a non-member package. - scorecard-enforcer: move the run: "Check minimum score" gate into a separate `enforce` job consuming the SARIF artifact, so the scorecard job stays uses-only (publish_results:true rejects mixed run/uses, 400). - docs/VERIFICATION-STANCE.adoc: replace the stale duplicate (claimed predicates vacuous / not end-to-end proven) with a redirect to the canonical verification/proofs/ copy; SPDX header preserved. Verified locally: corpus build exit 0, honesty-guard Clean, cargo clippy --bin vclt-gate -D expect_used -D unwrap_used rc=0, both workspaces resolve. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greens the three required CI gates that were red on
main(all verified locally), plus reconciles a stale duplicate doc. None of these touch SPDX/licence headers.Fixes
vclt-gatebin used a panicking.expect()inparse_vql_type. Replaced with amatchreturningErron the (logically impossible) empty-object case, and added#![deny(clippy::unwrap_used, clippy::expect_used)]to the bin so it meets the no-panic posture the lib already enforces.cargo test -p vcltotal-echidna-clientfailed (package ID did not match) because the crate isn't a root-workspace member (its transitiveechidna-corepath-dep breaks the standalone build). Gaveechidna-clientits own[workspace](standalone root, mirrorssrc/interface/parse) and switched the smoke step to--manifest-path.scorecardjob mixed arun:step withuses:whilepublish_results: true, which GitHub rejects (HTTP 400). Moved the minimum-score gate into a separateenforcejob consuming the SARIF as an artifact, so the scorecard job isuses:-only.docs/VERIFICATION-STANCE.adocwas a stale duplicate claiming the level predicates are vacuous / not end-to-end proven (false as of the proven corpus). Replaced with a redirect stub to the canonicalverification/proofs/VERIFICATION-STANCE.adoc; SPDX header preserved.Verified locally
idris2 --build verification/proofs/vclut-core.ipkgexit 0 ·honesty-guard.shClean ·cargo clippy --bin vclt-gate -- -D clippy::expect_used -D clippy::unwrap_usedrc=0 · both workspaces resolve ·actionlintclean on the scorecard workflow.🤖 Generated with Claude Code