Claude/jolly ramanujan 7lww m (#38)

Co-authored-by: Claude <noreply@anthropic.com>

Author: hyperpolymath

elixir-orchestration/test/verisim/consensus/kraft_node_test.exs

@@ -207,7 +207,7 @@ defmodule VeriSim.Consensus.KRaftNodeTest do
       # Find which one is leader
       leader_diag = KRaftNode.diagnostics(leader_id)
 
-      {actual_leader, actual_follower, actual_follower_pid} =
+      {actual_leader, actual_follower, _actual_follower_pid} =
         if leader_diag.role == :leader do
           {leader_id, follower_id, follower_pid}
         else

elixir-orchestration/test/verisim/consensus/kraft_recovery_test.exs

@@ -26,7 +26,7 @@ defmodule VeriSim.Consensus.KRaftRecoveryTest do
     "#{prefix}-#{System.unique_integer([:positive])}"
   end
 
-  defp start_node(node_id, opts \\ []) do
+  defp start_node(node_id, opts) do
     {:ok, pid} = KRaftNode.start_link([node_id: node_id] ++ opts)
     pid
   end

elixir-orchestration/test/verisim/query/vql_bridge_test.exs

@@ -0,0 +1,157 @@
+# SPDX-License-Identifier: MPL-2.0
+
+defmodule VeriSim.Query.VQLBridgeTest do
+  @moduledoc """
+  Tests for VeriSim.Query.VQLBridge — the Elixir↔Deno bridge for the
+  ReScript VQL parser.
+
+  When the external Deno/Node subprocess is unavailable (which is the
+  common case in CI without those runtimes), the bridge falls back to
+  a pure-Elixir built-in parser.  These tests exercise that fallback
+  path through the public GenServer API — they're guaranteed to hit
+  the fallback because no subprocess is started in the test
+  environment.
+
+  `typecheck/2` has no fallback (it requires the ReScript bidirectional
+  checker), so it must return `{:error, :type_checker_unavailable}`
+  when the port is nil.
+  """
+
+  use ExUnit.Case, async: false
+
+  alias VeriSim.Query.VQLBridge
+
+  setup do
+    case GenServer.whereis(VQLBridge) do
+      nil ->
+        {:ok, _pid} = VQLBridge.start_link([])
+        :ok
+
+      _pid ->
+        :ok
+    end
+
+    :ok
+  end
+
+  describe "parse/2 — built-in fallback" do
+    test "parses a simple SELECT query" do
+      assert {:ok, ast} = VQLBridge.parse("SELECT GRAPH FROM HEXAD abc-123")
+      assert is_map(ast)
+      assert Map.has_key?(ast, :modalities)
+      assert Map.has_key?(ast, :source)
+    end
+
+    test "parses multi-modality SELECT" do
+      assert {:ok, ast} = VQLBridge.parse("SELECT GRAPH, VECTOR, DOCUMENT FROM HEXAD abc-123")
+
+      assert :graph in ast.modalities
+      assert :vector in ast.modalities
+      assert :document in ast.modalities
+    end
+
+    test "parses SELECT * as :all" do
+      assert {:ok, ast} = VQLBridge.parse("SELECT * FROM HEXAD abc-123")
+      assert :all in ast.modalities
+    end
+
+    test "captures the source UUID from FROM HEXAD clause" do
+      assert {:ok, ast} = VQLBridge.parse("SELECT GRAPH FROM HEXAD entity-xyz")
+      assert match?({:octad, "entity-xyz"}, ast.source)
+    end
+
+    test "non-SELECT input returns {:error, _}" do
+      assert {:error, _} = VQLBridge.parse("HELLO WORLD")
+    end
+
+    test "empty string returns {:error, _}" do
+      assert {:error, _} = VQLBridge.parse("")
+    end
+  end
+
+  describe "parse_slipstream/2" do
+    test "accepts a query without PROOF" do
+      assert {:ok, _ast} = VQLBridge.parse_slipstream("SELECT GRAPH FROM HEXAD abc-123")
+    end
+
+    test "rejects a query with PROOF clause" do
+      assert {:error, msg} =
+               VQLBridge.parse_slipstream(
+                 "SELECT GRAPH FROM HEXAD abc-123 PROOF EXISTENCE(entity-001)"
+               )
+
+      assert is_binary(msg)
+      assert String.contains?(msg, "PROOF") or String.contains?(msg, "Slipstream")
+    end
+  end
+
+  describe "parse_dependent/2" do
+    test "rejects a query without PROOF clause" do
+      assert {:error, _msg} = VQLBridge.parse_dependent("SELECT GRAPH FROM HEXAD abc-123")
+    end
+
+    test "accepts a query with PROOF clause" do
+      assert {:ok, ast} =
+               VQLBridge.parse_dependent(
+                 "SELECT GRAPH FROM HEXAD abc-123 PROOF EXISTENCE(entity-001)"
+               )
+
+      assert ast.proof != nil
+    end
+  end
+
+  describe "parse_mutation/2" do
+    test "parses INSERT statement" do
+      assert {:ok, mutation} =
+               VQLBridge.parse_mutation("INSERT HEXAD WITH GRAPH {} AND VECTOR {}")
+
+      assert is_map(mutation)
+    end
+
+    test "parses UPDATE statement" do
+      assert {:ok, mutation} = VQLBridge.parse_mutation("UPDATE HEXAD abc-123 SET GRAPH {}")
+
+      assert is_map(mutation)
+    end
+
+    test "parses DELETE statement" do
+      assert {:ok, mutation} = VQLBridge.parse_mutation("DELETE HEXAD abc-123")
+      assert is_map(mutation)
+    end
+
+    test "non-mutation input returns {:error, _}" do
+      assert {:error, _} = VQLBridge.parse_mutation("SELECT GRAPH FROM HEXAD x")
+    end
+  end
+
+  describe "parse_statement/2" do
+    test "routes SELECT to Query tag" do
+      assert {:ok, %{TAG: "Query"}} = VQLBridge.parse_statement("SELECT GRAPH FROM HEXAD abc-123")
+    end
+
+    test "routes INSERT to Mutation tag" do
+      assert {:ok, %{TAG: "Mutation"}} =
+               VQLBridge.parse_statement("INSERT HEXAD WITH GRAPH {} AND VECTOR {}")
+    end
+
+    test "routes DELETE to Mutation tag" do
+      assert {:ok, %{TAG: "Mutation"}} = VQLBridge.parse_statement("DELETE HEXAD abc-123")
+    end
+  end
+
+  describe "typecheck/2" do
+    test "returns :type_checker_unavailable when no ReScript subprocess" do
+      # In test env the Deno/Node subprocess isn't started, so the
+      # typecheck handler returns this specific error rather than
+      # silently passing.  Critical for VQL-DT integrity.
+      ast = %{modalities: [:graph], source: {:octad, "abc"}}
+      assert {:error, :type_checker_unavailable} = VQLBridge.typecheck(ast)
+    end
+  end
+
+  describe "parse_and_execute/2 — error propagation" do
+    test "parse failure propagates" do
+      assert {:error, _} = VQLBridge.parse_and_execute("INVALID GIBBERISH", [])
+    end
+  end
+end

elixir-orchestration/test/verisim/query/vql_crossmodal_test.exs

@@ -33,7 +33,6 @@ defmodule VeriSim.Query.VQLCrossModalTest do
 
   use ExUnit.Case, async: false
 
-  alias VeriSim.Query.VQLBridge
   alias VeriSim.Test.VQLTestHelpers, as: H
 
   setup_all do

elixir-orchestration/test/verisim/query/vql_e2e_test.exs

@@ -28,7 +28,7 @@ defmodule VeriSim.Query.VQLE2ETest do
 
   use ExUnit.Case, async: false
 
-  alias VeriSim.Query.{VQLBridge, VQLExecutor, VQLTypeChecker, VQLProofCertificate}
+  alias VeriSim.Query.{VQLTypeChecker, VQLProofCertificate}
   alias VeriSim.Test.VQLTestHelpers, as: H
 
   setup_all do