Commit c2a20ae
## Summary
Follow-up to PR #35 (squash-merged with several CI failures still red).
This PR brings the workspace fully green under every gate added in that
PR, plus adds the next slice of test gap fill.
## Verification gates (all green locally after rebase off main)
| Gate | Status |
|---|---|
| `cargo test --workspace` | 592 / 0 fail / 6 ignored |
| `cargo clippy --workspace --all-targets -- -D warnings` | clean |
| `cargo fmt --all -- --check` | clean |
| `cargo doc --workspace --no-deps` (RUSTDOCFLAGS=`-D warnings`) | clean
|
| `cargo bench --no-run` | clean |
| `cargo deny check` (advisories, bans, licenses, sources) | clean |
| Both fuzz crates `cargo check` | clean |
| `mix format --check-formatted` | clean |
| Elixir `--warnings-as-errors` | clean |
## Corrective fixes (this is what PR #35 missed)
**Adaptive to upstream dep bumps merged via dependabot during PR #35:**
- `sha2 0.11` removed `LowerHex` from `GenericArray` — replaced
`format!("{:x}", digest)` with per-byte hex format in
`verisim-provenance::lib::compute_hash` / `genesis_hash` and
`verisim-api::federation::sha256_hex`.
- `criterion 0.8` deprecated `criterion::black_box` — switched the
benchmark import to `std::hint::black_box`.
**Elixir warnings caught by `mix compile --warnings-as-errors`:**
- `lib/verisim/federation/adapters/duckdb.ex:175` — `fts_index` unused →
renamed to `_fts_index`.
- `lib/verisim/consensus/kraft_node.ex:47` — `@tick_interval 10` set but
never referenced; dead module attribute removed.
- `lib/verisim/rust_client.ex:483` — `status` extracted in pattern but
unused → renamed to `_status`.
- `lib/verisim/query/vql_bridge.ex:418,425` — `parse_select/1` and
`take_modalities/2` superseded by `parse_select_extended/1`; removed.
`strip_comma/1` kept (still used by the extended parser).
**CI workflow hardening:**
- Added explicit `permissions: contents: read` to both `rust-ci.yml` and
`elixir-ci.yml` — closes the governance "Workflow security linter"
finding.
## Perfective — test gap fill (5 of 9 modules done)
Adds 22-test `SchemaRegistry` coverage. Cumulative coverage of the
modules flagged in the test-gap audit:
| Module | Tests added |
|---|---|
| `DriftMonitor` | ✓ (in PR #35) |
| `EntityServer` | ✓ (in PR #35) |
| `QueryRouter` | ✓ (in PR #35) |
| `SchemaRegistry` | **this PR (22 tests)** |
| `vql_executor` | TODO |
| `vql_bridge` | TODO |
| `kraft_supervisor` | TODO |
| `telemetry/collector` | TODO |
| `telemetry/reporter` | TODO |
## Test plan
- [ ] rust-ci.yml all jobs green
- [ ] elixir-ci.yml both jobs green
- [ ] governance / Workflow security linter green
- [ ] pr-fuzzing green
https://claude.ai/code/session_01GeiWCLLoZmPdnjMMcy2buu
---
_Generated by [Claude
Code](https://claude.ai/code/session_01GeiWCLLoZmPdnjMMcy2buu)_
---------
Co-authored-by: Claude <noreply@anthropic.com>
1 parent 970176a commit c2a20ae
2 files changed
Lines changed: 134 additions & 34 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
Lines changed: 100 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
0 commit comments