docs: CODEOWNERS-POLICY.adoc + bring CODEOWNERS into Rule 1 compliance - #213
Merged
Conversation
Two of the eight files #204 tracks, landed together because writing the policy document while violating the policy would have been self-contradictory. `.github/CODEOWNERS` carried six lines, every one naming the sole maintainer: * @hyperpolymath /rust-core/ @hyperpolymath /elixir-orchestration/ @hyperpolymath /src/vcl/ @hyperpolymath /container/ @hyperpolymath /.github/ @hyperpolymath The catch-all `*` and the `/.github/` line are precisely the two shapes `hyperpolymath/standards` CODEOWNERS-POLICY.adoc Rule 1 prohibits for solo-maintained repos, and the prohibition is not stylistic: * `*` requested a review from the sole maintainer on **every** PR, including every Dependabot bump — and this repo gets a lot of those. * `/.github/` fired again on workflow changes, so CI-touching PRs generated two requests rather than one. * Neither gated anything. A sole maintainer cannot be blocked on their own review, and the Base ruleset requires 0 approving reviews, so no merge was ever actually held by these lines. * Attribution never depended on them: every file carries an SPDX header and `reuse lint` enforces that at 100%. Replaced with the canonical comment-only header. Rule 3 (co-owner removal needs explicit confirmation) is **not** engaged — no line mapped to anyone other than the sole maintainer, so nobody's review gate was removed. Worth stating explicitly, since "deleting CODEOWNERS lines" is otherwise exactly the shape of change Rule 3 exists to prevent. `CODEOWNERS-POLICY.adoc` deliberately **references** the estate policy rather than forking it — a second copy would drift, and then the repo would have two policies disagreeing. What it adds is the conformance record: what this repo does, which rules are engaged, and why the removed lines were noise rather than control. That is the part that cannot live upstream. The doc names `GOVERNANCE.adoc` as not-yet-written and blocked on the TPCF perimeter ruling, rather than linking to it as though it exists. The gap is visible instead of implied. Verified: `tests/doc-consonance-gate.sh` passes (no "VeriSim Query Language" misnomer); `reuse lint` compliant — `REUSE.toml` already globs `**/*.adoc` to CC-BY-SA-4.0, so the new file needed no annotation change.
|
Note Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime. Code Review ✅ ApprovedAdds CODEOWNERS-POLICY.adoc and updates CODEOWNERS to remove redundant catch-all rules, bringing the configuration into Rule 1 compliance. No issues found.
OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|
|
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two of the eight files #204 tracks, landed together because writing the policy document while violating the policy would have been self-contradictory.
.github/CODEOWNERScarried six lines, every one naming the sole maintainer:The catch-all
*and the/.github/line are precisely the two shapeshyperpolymath/standardsCODEOWNERS-POLICY.adoc Rule 1 prohibits for solo-maintained repos, and the prohibition is not stylistic:*requested a review from the sole maintainer on every PR, including every Dependabot bump — and this repo gets a lot of those./.github/fired again on workflow changes, so CI-touching PRs generated two requests rather than one.reuse lintenforces that at 100%.Replaced with the canonical comment-only header. Rule 3 (co-owner removal needs explicit confirmation) is not engaged — no line mapped to anyone other than the sole maintainer, so nobody's review gate was removed. Worth stating explicitly, since "deleting CODEOWNERS lines" is otherwise exactly the shape of change Rule 3 exists to prevent.
CODEOWNERS-POLICY.adocdeliberately references the estate policy rather than forking it — a second copy would drift, and then the repo would have two policies disagreeing. What it adds is the conformance record: what this repo does, which rules are engaged, and why the removed lines were noise rather than control. That is the part that cannot live upstream.The doc names
GOVERNANCE.adocas not-yet-written and blocked on the TPCF perimeter ruling, rather than linking to it as though it exists. The gap is visible instead of implied.Verified:
tests/doc-consonance-gate.shpasses (no "VeriSim Query Language" misnomer);reuse lintcompliant —REUSE.tomlalready globs**/*.adocto CC-BY-SA-4.0, so the new file needed no annotation change.Summary
Closes #
Type of change
How has this been verified?
Checklist
git commit -S).SPDX-License-Identifier(code/configMPL-2.0,prose
CC-BY-SA-4.0); I did not relicense existing files.Notes for reviewers