Commit 52046ea
fix(ci): hypatia-scan PR-comment must not gate the scan
Canonical adoption got the scanner running (Clone/Build/Run all ✓) but
the 'Comment on PR with findings' step hard-failed: github-script@v7
with the default GITHUB_TOKEN got 'Resource not accessible by
integration' — the permissions block had no pull-requests: write and
the step had no continue-on-error, despite the template's own design
note that this step 'must NEVER hard-fail the scan' (hypatia#213).
Two-part at-source fix (latent canonical-template gap):
- permissions: add pull-requests: write so the advisory comment posts
- Comment step: continue-on-error: true so a token/API hiccup or a
fork PR (read-only token) skips the comment, never the check
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent c2e139a commit 52046ea
1 file changed
Lines changed: 10 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
28 | 33 | | |
29 | 34 | | |
30 | 35 | | |
| |||
211 | 216 | | |
212 | 217 | | |
213 | 218 | | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
214 | 224 | | |
215 | 225 | | |
216 | 226 | | |
| |||
0 commit comments