Skip to content

Commit d024028

Browse files
ci: make CI genuinely green — rust-ci toolchain pin + fmt/clippy (#57)
## Summary Make CI genuinely green. The shared rust-ci pin on `main` predates standards#439, so the SHA-pinned `dtolnay/rust-toolchain` step errors out before the job runs. This bumps the pin so rust-ci actually runs, and brings the Rust sources to fmt + clippy(`-D warnings`) clean under the CI toolchain (stable 1.96). ## Changes - **rust-ci:** bump `rust-ci-reusable.yml` pin `d135b05` → `8dc2bf0` (current `standards` HEAD; includes #439 toolchain fix + #441/#442). - **Rust hygiene:** `cargo fmt` + `clippy --fix` (`src/codegen/accessibility.rs`, `src/codegen/i18n.rs`) so `cargo fmt --all -- --check` and `cargo clippy --locked --all-targets -- -D warnings` pass. ## RSR Quality Checklist ### Required - [x] Tests pass (`cargo test --locked --all-targets`) - [x] Code is formatted (`cargo fmt --all -- --check`) - [x] Linter is clean (`cargo clippy --locked --all-targets -- -D warnings`) - [x] No banned language patterns - [x] SPDX license headers present on modified files - [x] No secrets, credentials, or `.env` files included ## Testing Verified locally with the CI toolchain (rustc/clippy/rustfmt 1.96.0): `cargo fmt --check`, `clippy -D warnings`, `cargo check --locked`, `cargo test --locked` all pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- _Generated by [Claude Code](https://claude.ai/code/session_01A6PSzJWpRxtzGDjUCEh7Mx)_ --------- Co-authored-by: Claude <noreply@anthropic.com>
1 parent a24a2cf commit d024028

3 files changed

Lines changed: 5 additions & 3 deletions

File tree

.github/workflows/rust-ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,4 @@ permissions:
1414

1515
jobs:
1616
rust-ci:
17-
uses: hyperpolymath/standards/.github/workflows/rust-ci-reusable.yml@d135b05bfc647d0c0fbfedc7e80f37ea50f49236
17+
uses: hyperpolymath/standards/.github/workflows/rust-ci-reusable.yml@8dc2bf039d1ff0372d650895c46bea7fbaec68ff

src/codegen/accessibility.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,8 @@ mod tests {
356356
criterion: "1.1.1".to_string(),
357357
}];
358358

359-
let report = generate_accessibility_report(&manifest, &violations).expect("TODO: handle error");
359+
let report =
360+
generate_accessibility_report(&manifest, &violations).expect("TODO: handle error");
360361
assert!(!report.passes); // should fail due to error-level violation
361362
assert_eq!(report.accessibility_violations_count, 1);
362363
}

src/codegen/i18n.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,8 @@ mod tests {
337337
context: None,
338338
}];
339339

340-
let files = generate_locale_files(&manifest, &strings, output_dir).expect("TODO: handle error");
340+
let files =
341+
generate_locale_files(&manifest, &strings, output_dir).expect("TODO: handle error");
341342
assert_eq!(files.len(), 2); // en-GB + fr-FR
342343

343344
// Check that the default locale file has the value.

0 commit comments

Comments
 (0)