Fix slider in image contrast editor on python >=3.10#76
Conversation
|
|
||
| self.control.slider.setLow(self._convert_to_slider(low)) | ||
| self.low = low | ||
| except: |
Check notice
Code scanning / CodeQL
Empty except
|
|
||
| self.control.slider.setHigh(self._convert_to_slider(high)) | ||
| self.high = high | ||
| except: |
Check notice
Code scanning / CodeQL
Empty except
| from traitsui.editors.api import RangeEditor | ||
| try: | ||
| from traitsui.qt.editor import Editor | ||
| except: |
Check notice
Code scanning / CodeQL
Except block handles 'BaseException'
|
|
||
| self.control.slider.setLow(self._convert_to_slider(low)) | ||
| self.low = low | ||
| except: |
Check notice
Code scanning / CodeQL
Except block handles 'BaseException'
| high = eval(str(self._label_hi.text()).strip()) | ||
| if self.evaluate is not None: | ||
| high = self.evaluate(high) | ||
| except: |
Check notice
Code scanning / CodeQL
Except block handles 'BaseException'
|
|
||
| self.control.slider.setHigh(self._convert_to_slider(high)) | ||
| self.high = high | ||
| except: |
Check notice
Code scanning / CodeQL
Except block handles 'BaseException'
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
- Coverage 47.34% 44.83% -2.51%
==========================================
Files 10 12 +2
Lines 452 707 +255
Branches 72 104 +32
==========================================
+ Hits 214 317 +103
- Misses 230 378 +148
- Partials 8 12 +4 ☔ View full report in Codecov by Sentry. |
1ced43c to
bbce235
Compare
… 2.1 is released
bbce235 to
96fae29
Compare
|
Merging this PR to release, to prepare to be able to release soon after hyperspy 2.1 is released. |
On python 3.10, the slider of the image contrast editor are broken:
Press on
hkey to open the image contrast editor and the percentile slider are missing.The error is:
xref enthought/traitsui#2048 for a fix in
traitsui.Needs hyperspy/hyperspy#3368