WIP

Author: suddendust

document-store/src/integrationTest/java/org/hypertrace/core/documentstore/MongoPostgresWriteConsistencyTest.java

@@ -456,7 +456,7 @@ void testCreateOrReplaceAndReturn(String storeName) throws Exception {
   }
 
   @Nested
-  class SubDocCompatibilityTest {
+  class SubdocUpdateConsistencyTests {
 
     @Nested
     @DisplayName("SET Operator Tests")
@@ -523,6 +523,29 @@ void testSetTopLevelArray(String storeName) throws Exception {
         assertEquals("tag6", tagsNode.get(2).asText());
       }
 
+      @ParameterizedTest(name = "{0}: SET top-level array")
+      @ArgumentsSource(AllStoresProvider.class)
+      void testSetTopLevelEmptyArray(String storeName) throws Exception {
+        String docId = generateDocId("set-array");
+        insertTestDocument(docId);
+
+        Collection collection = getCollection(storeName);
+        Query query = buildQueryById(docId);
+
+        List<SubDocumentUpdate> updates = List.of(SubDocumentUpdate.of("tags", new String[] {}));
+
+        UpdateOptions options =
+            UpdateOptions.builder().returnDocumentType(ReturnDocumentType.AFTER_UPDATE).build();
+
+        Optional<Document> result = collection.update(query, updates, options);
+
+        assertTrue(result.isPresent());
+        JsonNode resultJson = OBJECT_MAPPER.readTree(result.get().toJson());
+        JsonNode tagsNode = resultJson.get("tags");
+        assertTrue(tagsNode.isArray());
+        assertEquals(0, tagsNode.size(), storeName);
+      }
+
       @ParameterizedTest(name = "{0}: SET nested JSONB primitive")
       @ArgumentsSource(AllStoresProvider.class)
       void testSetNestedJsonbPrimitive(String storeName) throws Exception {
@@ -931,6 +954,90 @@ void testAddToListIfAbsentOnNonArrayField(String storeName) throws Exception {
       }
     }
 
+    @Nested
+    class AllOperatorTests {
+
+      @ParameterizedTest
+      @ArgumentsSource(AllStoresProvider.class)
+      void testMultipleUpdatesOnSameFieldThrowsException(String storeName) throws IOException {
+        String docId = generateDocId("multiple-updates-on-same-field");
+        insertTestDocument(docId);
+
+        Collection collection = getCollection(storeName);
+        Query query = buildQueryById(docId);
+
+        // top-level primitives
+        List<SubDocumentUpdate> topLevelPrimitiveUpdates =
+            List.of(
+                SubDocumentUpdate.builder()
+                    .subDocument("price")
+                    .operator(UpdateOperator.ADD)
+                    .subDocumentValue(SubDocumentValue.of(5))
+                    .build(),
+                SubDocumentUpdate.builder()
+                    .subDocument("price")
+                    .operator(UpdateOperator.ADD)
+                    .subDocumentValue(SubDocumentValue.of(-15))
+                    .build());
+
+        UpdateOptions options =
+            UpdateOptions.builder().returnDocumentType(ReturnDocumentType.AFTER_UPDATE).build();
+
+        // Since there are multiple updates on the same field, it should throw an exception
+        assertThrows(
+            Exception.class, () -> collection.update(query, topLevelPrimitiveUpdates, options));
+
+        // top-level arrays
+        List<SubDocumentUpdate> topLevelArrayUpdates =
+            List.of(
+                SubDocumentUpdate.builder()
+                    .subDocument("tags")
+                    .operator(UpdateOperator.APPEND_TO_LIST)
+                    .subDocumentValue(SubDocumentValue.of(new String[] {"tag1", "tag2"}))
+                    .build(),
+                SubDocumentUpdate.builder()
+                    .subDocument("tags")
+                    .operator(UpdateOperator.REMOVE_ALL_FROM_LIST)
+                    .subDocumentValue(SubDocumentValue.of(new String[] {"tag2"}))
+                    .build());
+
+        assertThrows(
+            Exception.class, () -> collection.update(query, topLevelArrayUpdates, options));
+
+        // nested array updates
+        List<SubDocumentUpdate> nestedArrayUpdates =
+            List.of(
+                SubDocumentUpdate.builder()
+                    .subDocument("sales.regions")
+                    .operator(UpdateOperator.SET)
+                    .subDocumentValue(SubDocumentValue.of(new String[] {"US", "EU", "APAC"}))
+                    .build(),
+                SubDocumentUpdate.builder()
+                    .subDocument("sales.regions")
+                    .operator(UpdateOperator.ADD_TO_LIST_IF_ABSENT)
+                    .subDocumentValue(SubDocumentValue.of(new String[] {"EMEA"}))
+                    .build());
+
+        assertThrows(Exception.class, () -> collection.update(query, nestedArrayUpdates, options));
+
+        // nested primitives
+        List<SubDocumentUpdate> nestedPrimitiveUpdates =
+            List.of(
+                SubDocumentUpdate.builder()
+                    .subDocument("props.brand")
+                    .operator(UpdateOperator.SET)
+                    .subDocumentValue(SubDocumentValue.of("NewBrand"))
+                    .build(),
+                SubDocumentUpdate.builder()
+                    .subDocument("props.brand")
+                    .operator(UpdateOperator.ADD_TO_LIST_IF_ABSENT)
+                    .subDocumentValue(SubDocumentValue.of("NewBrand2"))
+                    .build());
+
+        assertThrows(Exception.class, () -> collection.update(query, nestedArrayUpdates, options));
+      }
+    }
+
     @Nested
     @DisplayName("REMOVE_ALL_FROM_LIST Operator Tests")
     class RemoveAllFromListOperatorTests {

document-store/src/main/java/org/hypertrace/core/documentstore/postgres/FlatPostgresCollection.java

@@ -680,7 +680,7 @@ private Map<String, String> resolvePathsToColumns(
       UpdateOperator operator = update.getOperator();
 
       Preconditions.checkArgument(
-          SUB_DOC_UPDATE_PARSERS.containsKey(operator), "Unsupported UPDATE operator: " + operator);
+          UPDATE_PARSER_MAP.containsKey(operator), "Unsupported UPDATE operator: " + operator);
 
       String path = update.getSubDocument().getPath();
       Optional<String> columnName = resolveColumnName(path, tableName);