Skip to content

ENGTAI-68310 : Adding logic and fixing order#232

Merged
avinashkolluru merged 5 commits into
hypertrace:mainfrom
Sukhamjot-Singh:not-in-query
Oct 14, 2025
Merged

ENGTAI-68310 : Adding logic and fixing order#232
avinashkolluru merged 5 commits into
hypertrace:mainfrom
Sukhamjot-Singh:not-in-query

Conversation

@Sukhamjot-Singh
Copy link
Copy Markdown
Contributor

@Sukhamjot-Singh Sukhamjot-Singh commented Sep 9, 2025

Description

There a was a bug when using NOT_IN in the array pipeline.

Fixes two things

  • Mongo - NOT_IN -> $not and $in
  • Postgres - Alias -> lowercase

Copy link
Copy Markdown
Contributor

@suresh-prakash suresh-prakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can check-in your integration tests (in a generic way without specifying any proprietary information) so that any changes to this flow would be caught early on.

* IN" functionality by combining the $not and $in operators.
*/
@AllArgsConstructor
public class MongoStandardExprNotInRelationalFilterParser implements MongoRelationalFilterParser {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad on the naming suggestion earlier. Since we are special casing "NOT_IN", it is no longer a standard one.

Suggested change
public class MongoStandardExprNotInRelationalFilterParser implements MongoRelationalFilterParser {
public class MongoNotInExprRelationalFilterParser implements MongoRelationalFilterParser {

@Sukhamjot-Singh
Copy link
Copy Markdown
Contributor Author

You can check-in your integration tests (in a generic way without specifying any proprietary information) so that any changes to this flow would be caught early on.

I have added test for Mongo provider
I couldn't debug postgres issue

* environment IDs.
*/
@ParameterizedTest
@ArgumentsSource(MongoProvider.class)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything we build in document-store needs to be compatible with Postgres too to avoid digressing them too much. Could you please sync. with the respective team to get this working on Postgres too? I believe that should be a smaller fix too.

@Sukhamjot-Singh Sukhamjot-Singh changed the title Adding logic and fixing order ENGTAI-68310 : Adding logic and fixing order Sep 10, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.73%. Comparing base (4adcb5e) to head (3284d79).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...filter/MongoRelationalFilterParserFactoryImpl.java 40.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #232      +/-   ##
============================================
+ Coverage     79.71%   79.73%   +0.01%     
- Complexity     1098     1099       +1     
============================================
  Files           212      213       +1     
  Lines          5330     5344      +14     
  Branches        451      455       +4     
============================================
+ Hits           4249     4261      +12     
- Misses          762      763       +1     
- Partials        319      320       +1     
Flag Coverage Δ
integration 79.73% <62.50%> (+0.01%) ⬆️
unit 57.33% <12.50%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@avinashkolluru avinashkolluru merged commit 111e083 into hypertrace:main Oct 14, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants