ENGTAI-68310 : Adding logic and fixing order#232
Conversation
suresh-prakash
left a comment
There was a problem hiding this comment.
You can check-in your integration tests (in a generic way without specifying any proprietary information) so that any changes to this flow would be caught early on.
| * IN" functionality by combining the $not and $in operators. | ||
| */ | ||
| @AllArgsConstructor | ||
| public class MongoStandardExprNotInRelationalFilterParser implements MongoRelationalFilterParser { |
There was a problem hiding this comment.
My bad on the naming suggestion earlier. Since we are special casing "NOT_IN", it is no longer a standard one.
| public class MongoStandardExprNotInRelationalFilterParser implements MongoRelationalFilterParser { | |
| public class MongoNotInExprRelationalFilterParser implements MongoRelationalFilterParser { |
I have added test for Mongo provider |
| * environment IDs. | ||
| */ | ||
| @ParameterizedTest | ||
| @ArgumentsSource(MongoProvider.class) |
There was a problem hiding this comment.
Anything we build in document-store needs to be compatible with Postgres too to avoid digressing them too much. Could you please sync. with the respective team to get this working on Postgres too? I believe that should be a smaller fix too.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
============================================
+ Coverage 79.71% 79.73% +0.01%
- Complexity 1098 1099 +1
============================================
Files 212 213 +1
Lines 5330 5344 +14
Branches 451 455 +4
============================================
+ Hits 4249 4261 +12
- Misses 762 763 +1
- Partials 319 320 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
There a was a bug when using NOT_IN in the array pipeline.
Fixes two things