Skip to content

Add Additional dbcp2 configs#317

Merged
suddendust merged 4 commits into
mainfrom
dbcp2Configs
Jul 7, 2026
Merged

Add Additional dbcp2 configs#317
suddendust merged 4 commits into
mainfrom
dbcp2Configs

Conversation

@suddendust

@suddendust suddendust commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Description

This PR adds additional dbcp2 pool configurations as described here: https://commons.apache.org/proper/commons-dbcp/configuration.html

It also adds a minServerVersion driver config to avoid connection pinning as described here: https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/rds-proxy-pinning.html#rds-proxy-pinning.postgres

All of these configurations are optional, and the driver will assume defaults if they're not configured.

For this config:

        maxPoolSize =32
        minIdlePercent =100
        maxIdlePercent =100
        testOnBorrwo = false
        maxConnLifetime = "15 minutes"
        customParams {
          minServerVersion = "9.0"
        }

These are the logs:

2026-07-06 09:08:12.333 [main] DEBUG o.h.c.d.p.PostgresConnectionPool - Postgres connection pool properties - maxTotal: 32, maxIdle: 32, minIdle: 32, maxWaitMillis: 10000, testOnBorrow: null, testWhileIdle: null, timeBetweenEvictionRunsMillis: null, minEvictableIdleTimeMillis: null, maxConnLifetimeMillis: 900000, lifo: null
2026-07-06 09:11:30.007 [main] DEBUG o.h.c.d.m.c.p.PostgresConnectionConfig - Postgres JDBC properties - user=traceable_write, ApplicationName=entity-service, assumeMinServerVersion=9.0

@suddendust suddendust changed the title Dbcp2 configs Add Additional dbcp2 configs Jul 6, 2026
@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 49.15254% with 60 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.90%. Comparing base (c9d3e0a) to head (0d887ad).

Files with missing lines Patch % Lines
...config/TypesafeConfigDatastoreConfigExtractor.java 40.00% 12 Missing and 24 partials ⚠️
...documentstore/postgres/PostgresConnectionPool.java 27.27% 12 Missing and 12 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #317      +/-   ##
============================================
- Coverage     81.44%   80.90%   -0.54%     
- Complexity     1552     1579      +27     
============================================
  Files           242      242              
  Lines          7524     7626     +102     
  Branches        728      751      +23     
============================================
+ Hits           6128     6170      +42     
- Misses          943      967      +24     
- Partials        453      489      +36     
Flag Coverage Δ
integration 80.90% <49.15%> (-0.54%) ⬇️
unit 55.35% <49.15%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

Test Results

  124 files  ±0    124 suites  ±0   37s ⏱️ -5s
  845 tests +3    844 ✅ +3  1 💤 ±0  0 ❌ ±0 
1 182 runs  +3  1 181 ✅ +3  1 💤 ±0  0 ❌ ±0 

Results for commit 0d887ad. ± Comparison against base commit c9d3e0a.

@suddendust suddendust merged commit ec45778 into main Jul 7, 2026
5 of 7 checks passed
@suddendust suddendust deleted the dbcp2Configs branch July 7, 2026 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants