Add grpc circuit breaker utility using interceptors#68
Add grpc circuit breaker utility using interceptors#68pavan-traceable merged 15 commits intomainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
=============================================
- Coverage 71.80% 60.44% -11.36%
- Complexity 173 193 +20
=============================================
Files 26 35 +9
Lines 532 756 +224
Branches 26 45 +19
=============================================
+ Hits 382 457 +75
- Misses 126 269 +143
- Partials 24 30 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
...tils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/CircuitBreakerConfigProvider.java
Outdated
Show resolved
Hide resolved
...tils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/CircuitBreakerConfigProvider.java
Outdated
Show resolved
Hide resolved
...reaker-utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/CircuitBreakerModule.java
Outdated
Show resolved
Hide resolved
...reaker-utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/CircuitBreakerModule.java
Outdated
Show resolved
Hide resolved
...utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/CircuitBreakerEventListener.java
Outdated
Show resolved
Hide resolved
...r-utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/CircuitBreakerInterceptor.java
Outdated
Show resolved
Hide resolved
...r-utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/CircuitBreakerInterceptor.java
Outdated
Show resolved
Hide resolved
...r-utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/CircuitBreakerInterceptor.java
Outdated
Show resolved
Hide resolved
...r-utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/CircuitBreakerInterceptor.java
Outdated
Show resolved
Hide resolved
...tils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/CircuitBreakerConfigProvider.java
Outdated
Show resolved
Hide resolved
...tils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/CircuitBreakerConfigProvider.java
Outdated
Show resolved
Hide resolved
...utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/CircuitBreakerConfiguration.java
Outdated
Show resolved
Hide resolved
...org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerConfigParser.java
Outdated
Show resolved
Hide resolved
.../org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerInterceptor.java
Outdated
Show resolved
Hide resolved
.../org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerInterceptor.java
Outdated
Show resolved
Hide resolved
...utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/CircuitBreakerConfiguration.java
Outdated
Show resolved
Hide resolved
...-utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/CircuitBreakerConfigParser.java
Outdated
Show resolved
Hide resolved
...-utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/CircuitBreakerConfigParser.java
Outdated
Show resolved
Hide resolved
...org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerConfigParser.java
Outdated
Show resolved
Hide resolved
.../org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerInterceptor.java
Outdated
Show resolved
Hide resolved
.../org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerInterceptor.java
Outdated
Show resolved
Hide resolved
.../org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerInterceptor.java
Outdated
Show resolved
Hide resolved
.../org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerInterceptor.java
Outdated
Show resolved
Hide resolved
...hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerRegistryProvider.java
Outdated
Show resolved
Hide resolved
...-utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/CircuitBreakerConfigParser.java
Outdated
Show resolved
Hide resolved
.../org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerInterceptor.java
Outdated
Show resolved
Hide resolved
...ava/org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerProvider.java
Outdated
Show resolved
Hide resolved
...hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerRegistryProvider.java
Outdated
Show resolved
Hide resolved
...hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerRegistryProvider.java
Outdated
Show resolved
Hide resolved
.../org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerInterceptor.java
Show resolved
Hide resolved
.../org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerInterceptor.java
Outdated
Show resolved
Hide resolved
...-utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/CircuitBreakerConfigParser.java
Outdated
Show resolved
Hide resolved
...-utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/CircuitBreakerConfigParser.java
Outdated
Show resolved
Hide resolved
...-utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/CircuitBreakerConfigParser.java
Outdated
Show resolved
Hide resolved
...utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/CircuitBreakerConfiguration.java
Outdated
Show resolved
Hide resolved
...ava/org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerProvider.java
Outdated
Show resolved
Hide resolved
.../org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerInterceptor.java
Show resolved
Hide resolved
.../org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerInterceptor.java
Show resolved
Hide resolved
...java/org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerFactory.java
Outdated
Show resolved
Hide resolved
...java/org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerFactory.java
Outdated
Show resolved
Hide resolved
.../org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerInterceptor.java
Outdated
Show resolved
Hide resolved
.../org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerInterceptor.java
Outdated
Show resolved
Hide resolved
...-utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/CircuitBreakerConfigParser.java
Outdated
Show resolved
Hide resolved
...java/org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerFactory.java
Show resolved
Hide resolved
...ava/org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerProvider.java
Show resolved
Hide resolved
...ava/org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerProvider.java
Outdated
Show resolved
Hide resolved
...-utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/CircuitBreakerConfigParser.java
Show resolved
Hide resolved
...ava/org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerProvider.java
Outdated
Show resolved
Hide resolved
...ava/org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerProvider.java
Outdated
Show resolved
Hide resolved
...ava/org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerProvider.java
Outdated
Show resolved
Hide resolved
...ava/org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerProvider.java
Outdated
Show resolved
Hide resolved
...ava/org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerProvider.java
Outdated
Show resolved
Hide resolved
aaron-steinfeld
left a comment
There was a problem hiding this comment.
Thanks for working through all the comments on this one - this will be a nice add!
Left a couple minor nits that are just style prefs, but otherwise approved.
| .build( | ||
| new CacheLoader<>() { | ||
| @Override | ||
| public Optional<CircuitBreaker> load(String key) { | ||
| return buildNewCircuitBreaker(key); | ||
| } | ||
| }); |
There was a problem hiding this comment.
nit
| .build( | |
| new CacheLoader<>() { | |
| @Override | |
| public Optional<CircuitBreaker> load(String key) { | |
| return buildNewCircuitBreaker(key); | |
| } | |
| }); | |
| .build(CacheLoader.from(this::buildNewCircuitBreaker)); |
There was a problem hiding this comment.
Will fix in immediate PR, merging this
There was a problem hiding this comment.
| } else { | ||
| return Optional.empty(); | ||
| } | ||
| }); |
There was a problem hiding this comment.
nit - can do shared things at the end once you've built the circuit breaker
return Optional.ofNullable(circuitBreakerConfigMap.get(circuitBreakerKey))
.map(config -> circuitBreakerRegistry.circuitBreaker(circuitBreakerKey, config))
.or(() -> {
if (defaultEnabled) {
return Optional.of(circuitBreakerRegistry.circuitBreaker(circuitBreakerKey));
} else {
return Optional.empty();
}
})
.map(this::attachListeners); // assuming attach listeners can be made fluent and return the circuitbreaker
Description
Added grpc utility to support circuit breaker for slow and failure calls
Testing
Tested changes on sandbox environment using this utility.