Skip to content

Add Disable WAL support #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anujgoyal1 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add Disable WAL support #116

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c2ad12
Add Disable WAL support
anujgoyal1 Mar 2, 2026
2e43a3e
fix config key
anujgoyal1 Mar 2, 2026
316d2c1
fix options
anujgoyal1 Mar 2, 2026
1d947a3
fix options
anujgoyal1 Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...in/java/org/hypertrace/core/kafkastreams/framework/rocksdb/BoundedMemoryConfigSetter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import static org.hypertrace.core.kafkastreams.framework.rocksdb.RocksDBConfigs.MAX_SIZE_AMPLIFICATION_PERCENT;
import static org.hypertrace.core.kafkastreams.framework.rocksdb.RocksDBConfigs.OPTIMIZE_FOR_POINT_LOOKUPS;
import static org.hypertrace.core.kafkastreams.framework.rocksdb.RocksDBConfigs.PERIODIC_COMPACTION_SECONDS;
import static org.hypertrace.core.kafkastreams.framework.rocksdb.RocksDBConfigs.WAL_DISABLED;

import java.util.Map;
import org.apache.kafka.streams.state.RocksDBConfigSetter;
Expand All @@ -17,6 +18,7 @@
import org.rocksdb.CompressionType;
import org.rocksdb.InfoLogLevel;
import org.rocksdb.Options;
import org.rocksdb.WriteOptions;

public class BoundedMemoryConfigSetter implements RocksDBConfigSetter {

Expand Down Expand Up @@ -52,6 +54,12 @@ public void setConfig(String storeName, Options options, Map<String, Object> con
options.setUseDirectReads(Boolean.valueOf(String.valueOf(configs.get(DIRECT_READS_ENABLED))));
}

if (configs.containsKey(WAL_DISABLED)) {
Copy link
Copy Markdown

@puneet-traceable puneet-traceable Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need true/false or just key presence sufficient.

Copy link
Copy Markdown
Author

@anujgoyal1 anujgoyal1 Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes the impl, realised this might not be correct way

options.setWalDir("");
WriteOptions writeOptions = new WriteOptions();
writeOptions.setDisableWAL(true);
}

if (configs.containsKey(OPTIMIZE_FOR_POINT_LOOKUPS)) {
Boolean optimizeForPointLookups =
Boolean.valueOf(String.valueOf(configs.get(OPTIMIZE_FOR_POINT_LOOKUPS)));
Expand Down
1 change: 1 addition & 0 deletions ...work/src/main/java/org/hypertrace/core/kafkastreams/framework/rocksdb/RocksDBConfigs.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ public class RocksDBConfigs {
public static final String DIRECT_READS_ENABLED = rocksdbPrefix("direct.reads.enabled");
public static final String OPTIMIZE_FOR_POINT_LOOKUPS = rocksdbPrefix("optimize.point.lookups");
public static final String LOG_LEVEL_CONFIG = rocksdbPrefix("log.level");
public static final String WAL_DISABLED = rocksdbPrefix("disable.wal");

public static String rocksdbPrefix(String configKey) {
return ROCKS_DB_PREFIX + configKey;
Expand Down
Loading