Remove keyboard shortcut key

Author: karenrasmussen

src/shared/shortcut-config.ts

@@ -2,7 +2,6 @@ import { useEffect, useState } from 'preact/hooks';
 
 export type ShortcutId =
   | 'applyUpdates'
-  | 'openKeyboardShortcuts'
   | 'openSearch'
   | 'annotateSelection'
   | 'highlightSelection'
@@ -26,7 +25,6 @@ export type ShortcutDefinition = {
 // Default shortcuts
 const defaultShortcuts: ShortcutMap = {
   applyUpdates: 'l',
-  openKeyboardShortcuts: 'k',
   openSearch: '/',
   annotateSelection: 'a',
   highlightSelection: 'h',
@@ -168,12 +166,6 @@ export const shortcutDefinitions: ShortcutDefinition[] = [
     description: 'Loads new/updated annotations in the Sidebar.',
     group: 'Sidebar',
   },
-  {
-    id: 'openKeyboardShortcuts',
-    label: 'Open keyboard shortcuts',
-    description: 'Open the keyboard shortcuts settings.',
-    group: 'Sidebar',
-  },
   {
     id: 'openSearch',
     label: 'Search',

src/sidebar/components/UserMenu.tsx

@@ -1,8 +1,6 @@
 import { ProfileIcon } from '@hypothesis/frontend-shared';
-import { useCallback, useState } from 'preact/hooks';
+import { useState } from 'preact/hooks';
 
-import { useShortcut } from '../../shared/shortcut';
-import { useShortcutsConfig } from '../../shared/shortcut-config';
 import type { Service, SidebarSettings } from '../../types/config';
 import { serviceConfig } from '../config/service-config';
 import {
@@ -92,16 +90,6 @@ function UserMenu({ frameSync, onLogout, settings }: UserMenuProps) {
     </span>
   );
 
-  const shortcuts = useShortcutsConfig();
-
-  const openKeyboardShortcuts = useCallback((event?: KeyboardEvent) => {
-    event?.preventDefault();
-    setShortcutsOpen(true);
-    setOpen(false);
-  }, []);
-
-  useShortcut(shortcuts.openKeyboardShortcuts, openKeyboardShortcuts);
-
   return (
     <>
       {/* Allow keyboard shortcut 'n' to open Notebook */}

src/sidebar/components/test/UserMenu-test.js

@@ -13,7 +13,6 @@ describe('UserMenu', () => {
   let fakeSettings;
   let fakeStore;
   let fakeIsFeatureEnabled;
-  let fakeShortcuts;
 
   const createUserMenu = () => {
     return mount(
@@ -44,7 +43,6 @@ describe('UserMenu', () => {
     fakeServiceConfig = sinon.stub();
     fakeSettings = {};
     fakeIsFeatureEnabled = sinon.stub().returns(false);
-    fakeShortcuts = { openKeyboardShortcuts: 'k' };
     fakeStore = {
       defaultAuthority: sinon.stub().returns('hypothes.is'),
       focusedGroupId: sinon.stub().returns('mygroup'),
@@ -60,9 +58,6 @@ describe('UserMenu', () => {
         isThirdPartyUser: fakeIsThirdPartyUser,
       },
       '../config/service-config': { serviceConfig: fakeServiceConfig },
-      '../../shared/shortcut-config': {
-        useShortcutsConfig: () => fakeShortcuts,
-      },
       '../store': { useSidebarStore: () => fakeStore },
     });
   });
@@ -328,20 +323,6 @@ describe('UserMenu', () => {
 
       assert.isFalse(wrapper.find('KeyboardShortcutsModal').prop('open'));
     });
-
-    it('opens the shortcuts modal and closes the menu when shortcut is pressed', () => {
-      const wrapper = createUserMenu();
-
-      act(() => {
-        document.documentElement.dispatchEvent(
-          new KeyboardEvent('keydown', { key: 'k' }),
-        );
-      });
-      wrapper.update();
-
-      assert.isFalse(wrapper.find('Menu').props().open);
-      assert.isTrue(wrapper.find('KeyboardShortcutsModal').prop('open'));
-    });
   });
 
   describe('log out menu item', () => {