Skip to content

Fix typo in input placeholder color class #1940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acelaya merged 1 commit into from
Apr 9, 2025
Merged

Fix typo in input placeholder color class #1940

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/input/Input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export function inputStyles({ classes, feedback }: InputStylesOptions) {
return classnames(
'focus-visible-ring ring-inset border rounded w-full p-2',
'bg-grey-0 focus:bg-white disabled:bg-grey-1',
'placeholder:text-color-grey-5 disabled:placeholder:color-grey-6',
'placeholder:text-grey-6 disabled:placeholder:text-grey-7',
Copy link
Copy Markdown
Contributor Author

@acelaya acelaya Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither text-color-grey-5 or color-grey-6 were valid tailwind classes, but even if they were, grey-5 is too light in contrast with white.

Copy link
Copy Markdown
Contributor

@robertknight robertknight Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really ought to have a lint to check validity of classes. I suspect there was confusion here because we do have some custom text-color-* properties.

Copy link
Copy Markdown
Contributor Author

@acelaya acelaya Apr 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect there was confusion here because we do have some custom text-color-* properties.

Yep, that was also my thinking.


// On iOS, the input font size must be at least 16px to prevent the browser
// from zooming into it on touch.
Expand Down