Wrap Checkbox and RadioButton children in a span#2068
Merged
Conversation
This avoids a hazard where the Checkbox's flex layout can cause children to be displayed with an unexpected layout. See hypothesis/h#9844.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2068 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 71 71
Lines 1361 1361
Branches 509 509
=========================================
Hits 1361 1361 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
acelaya
approved these changes
Aug 21, 2025
robertknight
added a commit
to hypothesis/h
that referenced
this pull request
Aug 22, 2025
Update @hypothesis/frontend-shared and remove a layout workaround which is no longer needed due to hypothesis/frontend-shared#2068.
robertknight
added a commit
to hypothesis/h
that referenced
this pull request
Aug 22, 2025
Update @hypothesis/frontend-shared and remove a layout workaround which is no longer needed due to hypothesis/frontend-shared#2068.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids a hazard where the Checkbox's flex layout can cause children to be displayed with an unexpected layout. See hypothesis/h#9844.