Update npm-publish workflow to use trusted publishing#2116
Merged
Conversation
0ff753b to
ff83339
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2116 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 71 71
Lines 1364 1364
Branches 509 509
=========================================
Hits 1364 1364 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ff83339 to
a1a53c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the documentation at https://docs.npmjs.com/trusted-publishers, and after making the required changes in https://www.npmjs.com/package/@hypothesis/frontend-shared/access (only accessible to team members), this PR updates the
npm-publish.ymlworkflow to no longer publish packages using an npm token, and instead use trusted publishing.We are updating the workflow to use node 24 too, as trusted published requires a recent version of npm.