Skip to content

Commit 181dfe2

Browse files
committed
added comments
1 parent 9b76f39 commit 181dfe2

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

include/VCF_Constants.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -149,18 +149,18 @@ namespace VCFSystemConstants {
149149
constexpr int32_t DIGITAL_MIN_WITH_MARGINS_ADDR = 48;
150150
constexpr int32_t DIGITAL_MAX_WITH_MARGINS_ADDR = 52;
151151

152-
153152
// implausibility values
154153
constexpr float ANALOG_TOLERANCE = 0.05f; //+- 0.5% error (analog sensor tolerance according to datasheet)
155154
constexpr float DIGITAL_TOLERANCE = 0.05f; // +- 0.2 degrees error
156155
constexpr float ERROR_BETWEEN_SENSORS_TOLERANCE = 5.0f;
157156

158157
// rate of angle change
159158
constexpr float MAX_DTHETA_THRESHOLD = 50.0f; //maximum change in angle since last reading to consider the reading valid
159+
// TODO: find best value for this threshold
160160

161161
// degrees per bit
162-
constexpr float DEG_PER_COUNT_DIGITAL = 360.0f / 16384.0f;
163-
constexpr float DEG_PER_COUNT_ANALOG = 360.0f / 3603.6f;
162+
constexpr float DEG_PER_COUNT_DIGITAL = 360.0f / 16384.0f; // based on datasheet
163+
constexpr float DEG_PER_COUNT_ANALOG = 360.0f / 3603.6f; // based on VCF Rev3 readings
164164
}
165165

166166
// software configuration constants

0 commit comments

Comments
 (0)