Use field initialization shorthand (#7)

* Use field initialization shorthand

Manually reviewed by iCodeSometime

Author: deepsource-autofix[bot]

src/board_builder.rs

@@ -113,9 +113,9 @@ impl BoardBuilder {
     ) -> BoardBuilder {
         let mut result = BoardBuilder {
             pieces: [None; 64],
-            side_to_move: side_to_move,
+            side_to_move,
             castle_rights: [white_castle_rights, black_castle_rights],
-            en_passant: en_passant,
+            en_passant,
         };
 
         for piece in pieces.into_iter() {

src/cache_table.rs

@@ -48,10 +48,7 @@ impl<T: Copy + Clone + PartialEq + PartialOrd> CacheTable<T> {
     #[inline]
     pub fn add(&mut self, hash: u64, entry: T) {
         let e = unsafe { self.table.get_unchecked_mut((hash as usize) & self.mask) };
-        *e = CacheTableEntry {
-            hash: hash,
-            entry: entry,
-        };
+        *e = CacheTableEntry { hash, entry };
     }
 
     /// Replace an entry in the hash table with a user-specified replacement policy specified by
@@ -82,10 +79,7 @@ impl<T: Copy + Clone + PartialEq + PartialOrd> CacheTable<T> {
     pub fn replace_if<F: Fn(T) -> bool>(&mut self, hash: u64, entry: T, replace: F) {
         let e = unsafe { self.table.get_unchecked_mut((hash as usize) & self.mask) };
         if replace(e.entry) {
-            *e = CacheTableEntry {
-                hash: hash,
-                entry: entry,
-            };
+            *e = CacheTableEntry { hash, entry };
         }
     }
 }

src/chess_move.rs

@@ -24,9 +24,9 @@ impl ChessMove {
     #[inline]
     pub fn new(source: Square, dest: Square, promotion: Option<Piece>) -> ChessMove {
         ChessMove {
-            source: source,
-            dest: dest,
-            promotion: promotion,
+            source,
+            dest,
+            promotion,
         }
     }
 

src/gen_tables/magic.rs

@@ -75,7 +75,7 @@ fn generate_magic(sq: Square, piece: Piece, cur_offset: usize) -> usize {
 
     let mut new_magic = Magic {
         magic_number: EMPTY,
-        mask: mask,
+        mask,
         offset: new_offset as u32,
         rightshift: ((questions.len() as u64).leading_zeros() + 1) as u8,
     };

src/movegen/movegen.rs

@@ -22,7 +22,7 @@ impl SquareAndBitBoard {
         SquareAndBitBoard {
             square: sq,
             bitboard: bb,
-            promotion: promotion,
+            promotion,
         }
     }
 }