Update test files with more consistent usage of $this

Author: iMattPro

skeleton/tests/controller/main_test.php.twig

@@ -55,7 +55,7 @@ class main_test extends \phpbb_test_case
 			->getMock();
 
 		// Set the expected output of the controller_helper->render() method
-		$controller_helper->expects(self::once())
+		$controller_helper->expects($this->once())
 			->method('render')
 			->willReturnCallback(function ($template_file, $page_title = '', $status_code = 200, $display_online_list = false) {
 				return new \Symfony\Component\HttpFoundation\Response($template_file, $status_code);
@@ -70,8 +70,8 @@ class main_test extends \phpbb_test_case
 		);
 
 		$response = $controller->handle('test');
-		self::assertInstanceOf('\Symfony\Component\HttpFoundation\Response', $response);
-		self::assertEquals($status_code, $response->getStatusCode());
-		self::assertEquals($page_content, $response->getContent());
+		$this->assertInstanceOf('\Symfony\Component\HttpFoundation\Response', $response);
+		$this->assertEquals($status_code, $response->getStatusCode());
+		$this->assertEquals($page_content, $response->getContent());
 	}
 }

skeleton/tests/dbal/simple_test.php.twig

@@ -55,7 +55,7 @@ class simple_test extends \phpbb_database_test_case
 			$db_tools = $factory->get($this->db);
 		}
 
-		self::assertTrue($db_tools->sql_column_exists(USERS_TABLE, 'user_{{ EXTENSION.extension_name|lower }}'), 'Asserting that column "user_{{ EXTENSION.extension_name|lower }}" exists');
-		self::assertFalse($db_tools->sql_column_exists(USERS_TABLE, 'user_{{ EXTENSION.extension_name|lower }}_void'), 'Asserting that column "user_{{ EXTENSION.extension_name|lower }}_void" does not exist');
+		$this->assertTrue($db_tools->sql_column_exists(USERS_TABLE, 'user_{{ EXTENSION.extension_name|lower }}'), 'Asserting that column "user_{{ EXTENSION.extension_name|lower }}" exists');
+		$this->assertFalse($db_tools->sql_column_exists(USERS_TABLE, 'user_{{ EXTENSION.extension_name|lower }}_void'), 'Asserting that column "user_{{ EXTENSION.extension_name|lower }}_void" does not exist');
 	}
 }

skeleton/tests/functional/view_test.php.twig

@@ -30,11 +30,11 @@ class view_test extends \phpbb_functional_test_case
 	public function test_view_foo()
 	{
 		$crawler = self::request('GET', 'app.php/demo/foo');
-		self::assertStringContainsString('foo', $crawler->filter('h2')->text());
+		$this->assertStringContainsString('foo', $crawler->filter('h2')->text());
 
 		$this->add_lang_ext('{{ EXTENSION.vendor_name }}/{{ EXTENSION.extension_name }}', 'common');
-		self::assertStringContainsString($this->lang('{{ EXTENSION.extension_name|upper }}_HELLO', 'foo'), $crawler->filter('h2')->text());
-		self::assertStringNotContainsString($this->lang('{{ EXTENSION.extension_name|upper }}_GOODBYE', 'foo'), $crawler->filter('h2')->text());
+		$this->assertStringContainsString($this->lang('{{ EXTENSION.extension_name|upper }}_HELLO', 'foo'), $crawler->filter('h2')->text());
+		$this->assertStringNotContainsString($this->lang('{{ EXTENSION.extension_name|upper }}_GOODBYE', 'foo'), $crawler->filter('h2')->text());
 
 		$this->assertNotContainsLang('ACP_{{ EXTENSION.extension_name|upper }}_GOODBYE', $crawler->filter('h2')->text());
 	}
@@ -46,7 +46,7 @@ class view_test extends \phpbb_functional_test_case
 	public function test_view_bar()
 	{
 		$crawler = self::request('GET', 'app.php/demo/bar');
-		self::assertStringNotContainsString('foo', $crawler->filter('h2')->text());
-		self::assertStringContainsString('bar', $crawler->filter('h2')->text());
+		$this->assertStringNotContainsString('foo', $crawler->filter('h2')->text());
+		$this->assertStringContainsString('bar', $crawler->filter('h2')->text());
 	}
 }