Fixes

Author: iMicknl

pyproject.toml

@@ -80,6 +80,12 @@ select = [
 ]
 ignore = ["E501"] # Line too long
 
+[tool.ruff.lint.per-file-ignores]
+"tests/**" = [
+    "S101", # assert is standard in tests
+    "S106", # hardcoded passwords are acceptable in test fixtures
+]
+
 [tool.pytest.ini_options]
 asyncio_mode = "auto"
 testpaths = ["tests"]

sagemcom_api/client.py

@@ -128,7 +128,7 @@ async def close(self) -> None:
 
     def __generate_nonce(self, upper_limit=500000):
         """Generate pseudo random number (nonce) to avoid replay attacks."""
-        self._current_nonce = math.floor(random.randrange(0, upper_limit))
+        self._current_nonce = math.floor(random.randrange(0, upper_limit))  # noqa: S311 — router protocol requires this nonce
 
     def __generate_request_id(self):
         """Generate sequential request ID."""
@@ -138,7 +138,7 @@ def __generate_md5_nonce_hash(self):
         """Build MD5 with nonce hash token. UINT_MAX is hardcoded in the firmware."""
 
         def md5(input_string):
-            return hashlib.md5(input_string.encode()).hexdigest()
+            return hashlib.md5(input_string.encode()).hexdigest()  # noqa: S324 — MD5 required by router firmware
 
         n = self.__generate_nonce(UINT_MAX) if self._current_nonce is None else self._current_nonce
         f = 0
@@ -154,7 +154,7 @@ def __generate_hash(self, value, authentication_method=None):
         bytes_object = bytes(value, encoding="utf-8")
 
         if auth_method == EncryptionMethod.MD5:
-            return hashlib.md5(bytes_object).hexdigest()
+            return hashlib.md5(bytes_object).hexdigest()  # noqa: S324 — MD5 required by router firmware
 
         if auth_method == EncryptionMethod.SHA512:
             return hashlib.sha512(bytes_object).hexdigest()

tests/conftest.py

@@ -66,7 +66,7 @@ def xpath_value_response() -> dict[str, Any]:
 
 @pytest.fixture
 def mock_session_factory():
-    """Factory fixture for creating mock aiohttp ClientSession.
+    """Create a factory for mock aiohttp ClientSession.
 
     Returns a factory function that creates a mock session with configurable responses.
     Mock responses are consumed in sequence (first call gets first response, etc.).