Conversation
sometimes fontfamily of ContentPresenterEx is not propagated to its textblock content. In this case, the content of the repeat button is text, so a textblock is used instead.
|
@mou-haz Hi, thanks for your fix! It seems that I cannot conduct the test locally and I do not seem to know how to package |
|
I use a project reference instead of a nuget (these are the changes i used). I think this branch will be better for testing since it also has the expander fix. |
Jack251970
left a comment
Jack251970
left a comment
There was a problem hiding this comment.
It works for me! Thanks for your quick fix!!!❤️
Glad it worked ! you are welcome. |
There was a problem hiding this comment.
Pull request overview
This PR fixes a theming issue in the NumberBox control where theme resources were not switching properly between light and dark themes. The fix replaces the merged resource dictionaries approach with a custom RepeatButton template that directly references theme resources.
Key changes:
- Added a custom RepeatButton template with direct DynamicResource references to TextControlButton* resources
- Removed Grid.Resources section with theme-specific resource mappings
- Added Foreground and FocusVisualStyle setters to the NumberBoxSpinButtonStyle
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@NotYoojun Sorry for pinging. Do you have any plan to provide a quick fix version? |
According to the case reported by @Jack251970 in reply, it seems in some cases the included merged resource dictionaries don't provide the correct theme resources (it seems to only provide the light theme resources by default?).
This PR uses a custom RepeatButton style that uses the needed resources instead.
Remaining issues:
Popup icons.After changes:
numberBox.mp4