PINIO: fix operand order for backward compat, unify pinioSet/pinioSetDuty

Swap PINIO_PWM operands so operandA=duty, operandB=pin, matching the old
LED_PIN_PWM behavior (operandA=duty only) for backward compatibility.
Pin numbering: 0=LED pin, 1=USER1, 2=USER2, etc.

Consolidate pinioSet into pinioSetDuty: on/off is just PWM at 0% or 100%
duty. pinioSetDuty now handles both timer and GPIO pins; pinioSet becomes
a one-liner wrapper. Removes redundant state tracking field.

Author: sensei-hacker

src/main/drivers/pinio.c

@@ -67,7 +67,6 @@ typedef struct pinioRuntime_s {
     IO_t io;
     TCH_t *tch;     // Non-NULL when pin is configured in PWM mode
     bool inverted;
-    bool state;
 } pinioRuntime_t;
 
 static pinioRuntime_t pinioRuntime[PINIO_COUNT];
@@ -103,7 +102,6 @@ void pinioInit(void)
                 pinioRuntime[i].tch = tch;
                 pinioRuntime[i].io = io;
                 pinioRuntime[i].inverted = (pinioHardware[i].flags & PINIO_FLAGS_INVERTED) != 0;
-                pinioRuntime[i].state = false;
                 // Start in the "off" state: HIGH if inverted, LOW if normal
                 *timerCCR(tch) = pinioRuntime[i].inverted ? 100 : 0;
                 continue;
@@ -123,11 +121,10 @@ void pinioInit(void)
         }
 
         pinioRuntime[i].io = io;
-        pinioRuntime[i].state = false;
     }
 }
 
-void pinioSet(int index, bool newState)
+void pinioSetDuty(int index, uint8_t duty)
 {
     if (index < 0 || index >= pinioHardwareCount) {
         return;
@@ -137,30 +134,23 @@ void pinioSet(int index, bool newState)
         return;
     }
 
-    if (newState != pinioRuntime[index].state) {
-        if (pinioRuntime[index].tch) {
-            *timerCCR(pinioRuntime[index].tch) = (newState ^ pinioRuntime[index].inverted) ? 100 : 0;
-        } else {
-            IOWrite(pinioRuntime[index].io, newState ^ pinioRuntime[index].inverted);
-        }
-        pinioRuntime[index].state = newState;
-    }
-}
-
-void pinioSetDuty(int index, uint8_t duty)
-{
-    if (index < 0 || index >= pinioHardwareCount) {
-        return;
+    // Clamp to valid range
+    if (duty > 100) {
+        duty = 100;
     }
 
-    if (!pinioRuntime[index].tch) {
-        return;
+    if (pinioRuntime[index].tch) {
+        // Timer-capable pin: set PWM duty cycle directly
+        *timerCCR(pinioRuntime[index].tch) = pinioRuntime[index].inverted ? (100 - duty) : duty;
+    } else {
+        // GPIO pin: treat as on/off (0 = off, any non-zero = on)
+        IOWrite(pinioRuntime[index].io, (duty > 0) ^ pinioRuntime[index].inverted);
     }
+}
 
-    // Clamp to valid range and apply inversion
-    if (duty > 100) {
-        duty = 100;
-    }
-    *timerCCR(pinioRuntime[index].tch) = pinioRuntime[index].inverted ? (100 - duty) : duty;
+// pinioSet is a convenience wrapper: on/off is just PWM at 100% or 0% duty
+void pinioSet(int index, bool newState)
+{
+    pinioSetDuty(index, newState ? 100 : 0);
 }
 #endif

src/main/programming/logic_condition.c

@@ -509,17 +509,16 @@ static int logicConditionCompute(
 
 #ifdef USE_PINIO
         case LOGIC_CONDITION_PINIO_PWM:
-            // operandA = channel, operandB = duty cycle (0-100)
-            // Channels 0..PINIO_COUNT-1 = hardware PINIO (PWM capable)
-            // Channel PINIO_COUNT = LED strip idle level (binary: >0 = HIGH)
+            // operandA = duty cycle (0-100), operandB = pin (0=LED pin, 1=USER1, 2=USER2, ...)
+            // operandB=0 preserves backward compatibility with old LED_PIN_PWM behavior
+            if (operandB == 0) {
 #ifdef USE_LED_STRIP
-            if (operandA == PINIO_COUNT) {
-                ws2811SetIdleHigh(operandB > 0);
-                return operandB;
-            }
+                ws2811SetIdleHigh(operandA > 0);
 #endif
-            pinioSetDuty(operandA, (uint8_t)constrain(operandB, 0, 100));
-            return operandB;
+                return operandA;
+            }
+            pinioSetDuty(operandB - 1, (uint8_t)constrain(operandA, 0, 100));
+            return operandA;
             break;
 #endif
 #ifdef USE_GPS_FIX_ESTIMATION