fix(beeper): report PWM init failure instead of failing silently

beeperPwmInit() now returns bool. beeperInit() checks it on both the
runtime-assigned pad and the compile-time fallback pad, logging an
error via LOG_ERROR(PWM, ...) on failure. The runtime path does not
fall through to the compile-time pin on failure, since that pin may
have been reassigned to another function.

Addresses Qodo review finding on PR #11675.

Author: sensei-hacker

src/main/drivers/pwm_output.c

@@ -764,7 +764,7 @@ void pwmWriteBeeper(bool onoffBeep)
     }
 }
 
-void beeperPwmInit(ioTag_t tag, uint16_t frequency)
+bool beeperPwmInit(ioTag_t tag, uint16_t frequency)
 {
     beeperPwm = NULL;
 
@@ -774,14 +774,17 @@ void beeperPwmInit(ioTag_t tag, uint16_t frequency)
         // Attempt to allocate TCH
         TCH_t * tch = timerGetTCH(timHw);
         if (tch == NULL) {
-            return;
+            return false;
         }
 
         beeperPwm = &beeperPwmPort;
         beeperFrequency = frequency;
         IOConfigGPIOAF(IOGetByTag(tag), IOCFG_AF_PP, timHw->alternateFunction);
         pwmOutConfigTimer(beeperPwm, tch, PWM_TIMER_HZ, 1000000 / beeperFrequency, (1000000 / beeperFrequency) / 2);
+        return true;
     }
+
+    return false;
 }
 
 #endif

src/main/drivers/pwm_output.h

@@ -59,7 +59,7 @@ bool pwmMotorConfig(const struct timerHardware_s *timerHardware, uint8_t motorIn
 void pwmServoPreconfigure(void);
 bool pwmServoConfig(const struct timerHardware_s *timerHardware, uint8_t servoIndex, uint16_t servoPwmRate, uint16_t servoCenterPulse, bool enableOutput);
 void pwmWriteBeeper(bool onoffBeep);
-void beeperPwmInit(ioTag_t tag, uint16_t frequency);
+bool beeperPwmInit(ioTag_t tag, uint16_t frequency);
 
 void sendDShotCommand(dshotCommands_e cmd);
 void initDShotCommands(void);

src/main/drivers/sound_beeper.c

@@ -23,6 +23,7 @@
 #include "drivers/time.h"
 #include "drivers/io.h"
 
+#include "common/log.h"
 #include "drivers/timer.h"
 #include "drivers/pwm_mapping.h"
 #include "drivers/pwm_output.h"
@@ -84,7 +85,10 @@ void beeperInit(const beeperDevConfig_t *config)
     for (int idx = 0; idx < timerHardwareCount; idx++) {
         const timerHardware_t *timHw = &timerHardware[idx];
         if (timerOverrides(timer2id(timHw->tim))->outputMode == OUTPUT_MODE_BEEPER) {
-            beeperPwmInit(timHw->tag, BEEPER_PWM_FREQUENCY);
+            if (!beeperPwmInit(timHw->tag, BEEPER_PWM_FREQUENCY)) {
+                LOG_ERROR(PWM, "Beeper PWM init failed on assigned pad, beeper disabled");
+                return;
+            }
             beeperConfigMutable()->pwmMode = true;
             systemBeep(false);
             return;
@@ -107,7 +111,9 @@ void beeperInit(const beeperDevConfig_t *config)
     if (beeperIO) {
         IOInit(beeperIO, OWNER_BEEPER, RESOURCE_OUTPUT, 0);
         if (beeperConfig()->pwmMode) {
-            beeperPwmInit(config->ioTag, BEEPER_PWM_FREQUENCY);
+            if (!beeperPwmInit(config->ioTag, BEEPER_PWM_FREQUENCY)) {
+                LOG_ERROR(PWM, "Beeper PWM init failed on compile-time pad, beeper disabled");
+            }
         } else {
             IOConfigGPIO(beeperIO, config->isOD ? IOCFG_OUT_OD : IOCFG_OUT_PP);
         }