Skip to content

Commit c5bfd54

Browse files
committed
resolve comments
1 parent 2e2f564 commit c5bfd54

3 files changed

Lines changed: 8 additions & 6 deletions

File tree

source/api_c/src/c_api.cc

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,8 @@ void DP_NlistSetMapping(DP_Nlist* nl, int* mapping) {
4949
void DP_DeleteNlist(DP_Nlist* nl) { delete nl; }
5050

5151
// DP Base Model
52-
DP_DeepBaseModel::DP_DeepBaseModel() {}
52+
DP_DeepBaseModel::DP_DeepBaseModel()
53+
: dfparam(0), daparam(0), aparam_nall(false), has_default_fparam(false) {}
5354
DP_DeepBaseModel::DP_DeepBaseModel(deepmd::DeepBaseModel& dpbase)
5455
: dpbase(dpbase) {
5556
dfparam = dpbase.dim_fparam();
@@ -60,7 +61,8 @@ DP_DeepBaseModel::DP_DeepBaseModel(deepmd::DeepBaseModel& dpbase)
6061
void DP_DeleteDeepBaseModel(DP_DeepBaseModel* dpbase) { delete dpbase; }
6162

6263
// DP Base Model Devi
63-
DP_DeepBaseModelDevi::DP_DeepBaseModelDevi() {}
64+
DP_DeepBaseModelDevi::DP_DeepBaseModelDevi()
65+
: dfparam(0), daparam(0), aparam_nall(false), has_default_fparam(false) {}
6466
DP_DeepBaseModelDevi::DP_DeepBaseModelDevi(deepmd::DeepBaseModelDevi& dpbase)
6567
: dpbase(dpbase) {
6668
dfparam = dpbase.dim_fparam();

source/api_cc/src/DeepPotPT.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,9 +146,9 @@ void DeepPotPT::init(const std::string& model,
146146
dfparam = module.run_method("get_dim_fparam").toInt();
147147
daparam = module.run_method("get_dim_aparam").toInt();
148148
aparam_nall = module.run_method("is_aparam_nall").toBool();
149-
try {
149+
if (module.find_method("has_default_fparam")) {
150150
has_default_fparam_ = module.run_method("has_default_fparam").toBool();
151-
} catch (...) {
151+
} else {
152152
has_default_fparam_ = false;
153153
}
154154
inited = true;

source/api_cc/src/DeepSpinPT.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,9 +118,9 @@ void DeepSpinPT::init(const std::string& model,
118118
dfparam = module.run_method("get_dim_fparam").toInt();
119119
daparam = module.run_method("get_dim_aparam").toInt();
120120
aparam_nall = module.run_method("is_aparam_nall").toBool();
121-
try {
121+
if (module.find_method("has_default_fparam")) {
122122
has_default_fparam_ = module.run_method("has_default_fparam").toBool();
123-
} catch (...) {
123+
} else {
124124
has_default_fparam_ = false;
125125
}
126126
inited = true;

0 commit comments

Comments
 (0)