fix: cap initial buffer for live radio

Author: Alexsatter

README.md

@@ -160,7 +160,7 @@ in mpv; if no station has been started yet, it is ignored.
 | key | action |
 | --- | --- |
 | `j` / `↓` · `k` / `↑` | select setting |
-| `h` / `←` · `l` / `→` | adjust by 5 seconds |
+| `h` / `←` · `l` / `→` | adjust by 5 seconds (`initial buffer` is capped at 10s) |
 | `0` | turn selected setting off |
 | `enter` | save |
 | `esc` | cancel |
@@ -241,7 +241,7 @@ on first run with sensible defaults; a documented example sits at
 theme: tokyo-night        # see Themes below for all built-in theme ids
 volume: 60                # initial volume, 0–100
 buffer_seconds: 30        # network read-ahead; try 60–120 on flaky Wi-Fi
-initial_buffer_seconds: 0 # wait before start/resume; try 5–10 if streams stutter
+initial_buffer_seconds: 0 # wait before start/resume; capped at 10s for live radio
 
 stations:
   - name: SomaFM Groove Salad

README.ru.md

@@ -164,7 +164,7 @@ lofi-player
 | клавиша | действие |
 | --- | --- |
 | `j` / `↓` · `k` / `↑` | выбрать настройку |
-| `h` / `←` · `l` / `→` | изменить на 5 секунд |
+| `h` / `←` · `l` / `→` | изменить на 5 секунд (`initial buffer` максимум 10с) |
 | `0` | выключить выбранную настройку |
 | `enter` | сохранить |
 | `esc` | отмена |
@@ -247,7 +247,7 @@ lofi-player --import - < stations.yaml
 theme: tokyo-night        # все встроенные id см. в разделе «Темы»
 volume: 60                # стартовая громкость, 0–100
 buffer_seconds: 30        # сетевой запас; для плохого Wi-Fi попробуй 60–120
-initial_buffer_seconds: 0 # ждать перед стартом/возобновлением; попробуй 5–10
+initial_buffer_seconds: 0 # ждать перед стартом/возобновлением; максимум 10с для live-radio
 
 stations:
   - name: SomaFM Groove Salad

internal/audio/player.go

@@ -109,6 +109,8 @@ type Options struct {
 	BufferSeconds int
 	// InitialBufferSeconds makes mpv wait for this many seconds of cache
 	// before starting/resuming after a cache stall. 0 starts immediately.
+	// Values above 10 are clamped because many live-radio streams never
+	// build a deeper initial cache and would appear stuck.
 	InitialBufferSeconds int
 }
 
@@ -141,7 +143,11 @@ type Player struct {
 	lastCacheSec float64
 }
 
-const mainInputConf = "PAUSE cycle pause\n"
+const (
+	mainInputConf           = "PAUSE cycle pause\n"
+	maxBufferSeconds        = 600
+	maxInitialBufferSeconds = 10
+)
 
 func mainMPVArgs(socketPath string, opts Options) []string {
 	args := []string{
@@ -162,8 +168,8 @@ func mainMPVArgs(socketPath string, opts Options) []string {
 }
 
 func networkCacheArgs(opts Options) []string {
-	bufferSec := clampSeconds(opts.BufferSeconds, 0, 600)
-	initialSec := clampSeconds(opts.InitialBufferSeconds, 0, 120)
+	bufferSec := clampSeconds(opts.BufferSeconds, 0, maxBufferSeconds)
+	initialSec := clampSeconds(opts.InitialBufferSeconds, 0, maxInitialBufferSeconds)
 	if initialSec > bufferSec {
 		bufferSec = initialSec
 	}

internal/audio/player_test.go

@@ -235,10 +235,10 @@ func TestMainMPVArgsConfigureNetworkBuffer(t *testing.T) {
 	}
 }
 
-func TestMainMPVArgsInitialBufferExtendsReadahead(t *testing.T) {
+func TestMainMPVArgsInitialBufferIsCappedForLiveRadio(t *testing.T) {
 	args := mainMPVArgs("/tmp/lofi-player-test.sock", Options{InitialBufferSeconds: 45})
-	if !hasArg(args, "--demuxer-readahead-secs=45") {
-		t.Fatalf("main mpv args %v did not extend readahead to initial buffer", args)
+	if !hasArg(args, "--demuxer-readahead-secs=10") || !hasArg(args, "--cache-pause-wait=10") {
+		t.Fatalf("main mpv args %v did not cap initial buffer to 10s", args)
 	}
 }
 

internal/tui/model_test.go

@@ -265,7 +265,12 @@ func TestSettingsModalAdjustSaveAndCancel(t *testing.T) {
 		t.Fatalf("saved buffer settings = %d/%d, want 35/10", cfg.BufferSeconds, cfg.InitialBufferSeconds)
 	}
 
-	m = send(t, m, "o", "0", "esc")
+	m = send(t, m, "o", "j", "l")
+	if m.settingsInitialBufferSeconds != 10 {
+		t.Fatalf("initial buffer exceeded cap: got %d, want 10", m.settingsInitialBufferSeconds)
+	}
+
+	m = send(t, m, "0", "esc")
 	if cfg.BufferSeconds != 35 || cfg.InitialBufferSeconds != 10 {
 		t.Fatalf("cancel changed config to %d/%d", cfg.BufferSeconds, cfg.InitialBufferSeconds)
 	}

internal/tui/update.go

@@ -15,7 +15,11 @@ import (
 	"github.com/iRootPro/lofi-player/internal/theme"
 )
 
-const volumeStep = 5
+const (
+	volumeStep                = 5
+	settingsMaxBufferSeconds  = 600
+	settingsMaxInitialSeconds = 10
+)
 
 // Update applies a message to the model and returns the new model plus
 // any commands to run. Receiver is by value; never mutate m through a
@@ -429,8 +433,8 @@ func (m Model) openSettings() Model {
 	m.modePrev = m.mode
 	m.mode = modeSettings
 	m.settingsCursor = 0
-	m.settingsBufferSeconds = m.cfg.BufferSeconds
-	m.settingsInitialBufferSeconds = m.cfg.InitialBufferSeconds
+	m.settingsBufferSeconds = clampInt(m.cfg.BufferSeconds, 0, settingsMaxBufferSeconds)
+	m.settingsInitialBufferSeconds = clampInt(m.cfg.InitialBufferSeconds, 0, settingsMaxInitialSeconds)
 	return m
 }
 
@@ -443,9 +447,9 @@ func (m Model) updateSettings(msg tea.Msg) (tea.Model, tea.Cmd) {
 	adjust := func(delta int) {
 		switch m.settingsCursor {
 		case 0:
-			m.settingsBufferSeconds = clampInt(m.settingsBufferSeconds+delta, 0, 600)
+			m.settingsBufferSeconds = clampInt(m.settingsBufferSeconds+delta, 0, settingsMaxBufferSeconds)
 		case 1:
-			m.settingsInitialBufferSeconds = clampInt(m.settingsInitialBufferSeconds+delta, 0, 120)
+			m.settingsInitialBufferSeconds = clampInt(m.settingsInitialBufferSeconds+delta, 0, settingsMaxInitialSeconds)
 		}
 	}
 	zero := func() {

internal/tui/view.go

@@ -238,7 +238,7 @@ func (m Model) viewSettings() string {
 		{
 			label: "initial buffer",
 			value: formatSettingsSeconds(m.settingsInitialBufferSeconds, "off"),
-			desc:  "wait before start/resume after cache stalls",
+			desc:  "wait before start/resume, capped at 10s for live radio",
 		},
 	}