File tree Expand file tree Collapse file tree
src/main/java/io/swaglabs/portal/qa/browsermanager Expand file tree Collapse file tree Original file line number Diff line number Diff line change 55public class BrowserFactory {
66
77 public IBrowser createBrowser () {
8- return switch (BrowserName .fromString (WebPortalConstants .BROWSER )) {
8+ return switch (BrowserName .fromConfigValue (WebPortalConstants .BROWSER )) {
99 case FIREFOX -> new FirefoxBrowser ();
1010 case WEBKIT -> new WebkitBrowser ();
1111 case MS_EDGE -> new MsEdgeBrowser ();
Original file line number Diff line number Diff line change @@ -11,6 +11,7 @@ public class BrowserManager implements IBrowserManager<Page> {
1111
1212 @ Override
1313 public Page getBrowserPage (Playwright playwright ) {
14+ Objects .requireNonNull (playwright , "Playwright instance is null in Browser Manager!" );
1415 boolean isHeadless = "headless" .equals (WebPortalConstants .RUN_MODE );
1516 BrowserContext browserContext = new BrowserFactory ().createBrowser ().createSession (playwright , isHeadless );
1617 Objects .requireNonNull (browserContext , "Playwright Browser Context is null!" );
Original file line number Diff line number Diff line change 55import lombok .Getter ;
66
77import java .util .Arrays ;
8+ import java .util .Objects ;
89
910@ Getter
1011@ AllArgsConstructor
@@ -17,7 +18,8 @@ public enum BrowserName {
1718
1819 private final String browserType ;
1920
20- public static BrowserName fromString (String browserName ) {
21+ public static BrowserName fromConfigValue (String browserName ) {
22+ Objects .requireNonNull (browserName , "Browser name cannot be null" );
2123 return Arrays .stream (BrowserName .values ())
2224 .filter (browserType -> browserType .getBrowserType ().equalsIgnoreCase (browserName ))
2325 .findFirst ().orElseThrow (() -> new WebUtilsException ("Unknown browser: " + browserName ));
You can’t perform that action at this time.
0 commit comments