Refactored Screenshot Strategy.

Author: iamcharankumar

src/main/java/io/swaglabs/portal/qa/browsermanager/ChromeBrowser.java

@@ -6,11 +6,14 @@
 import com.microsoft.playwright.Playwright;
 import io.swaglabs.portal.qa.constants.WebPortalConstants;
 
+import java.util.List;
+
 public class ChromeBrowser implements IBrowser {
 
     @Override
     public BrowserContext createSession(Playwright playwright, boolean isHeadless) {
-        BrowserType.LaunchOptions chromeLaunchOptions = WebPortalConstants.BROWSER_LAUNCH_OPTIONS.setHeadless(isHeadless);
+        BrowserType.LaunchOptions chromeLaunchOptions = WebPortalConstants.BROWSER_LAUNCH_OPTIONS.setHeadless(isHeadless)
+                .setArgs(List.of("--window-position=0,0"));
         return playwright.chromium().launch(chromeLaunchOptions).newContext(new Browser.NewContextOptions()
                 .setViewportSize(WebPortalConstants.SCREEN_WIDTH, WebPortalConstants.SCREEN_HEIGHT)
                 .setTimezoneId(WebPortalConstants.TIME_ZONE));

src/main/java/io/swaglabs/portal/qa/browsermanager/MsEdgeBrowser.java

@@ -6,12 +6,15 @@
 import com.microsoft.playwright.Playwright;
 import io.swaglabs.portal.qa.constants.WebPortalConstants;
 
+import java.util.List;
+
 public class MsEdgeBrowser implements IBrowser {
     @Override
     public BrowserContext createSession(Playwright playwright, boolean isHeadless) {
         BrowserType.LaunchOptions msedgeLaunchOptions = WebPortalConstants.BROWSER_LAUNCH_OPTIONS
                 .setHeadless(isHeadless)
-                .setChannel(BrowserName.MS_EDGE.getBrowserType());
+                .setChannel(BrowserName.MS_EDGE.getBrowserType())
+                .setArgs(List.of("--window-position=0,0"));
         return playwright.chromium().launch(msedgeLaunchOptions).newContext(new Browser.NewContextOptions()
                 .setViewportSize(WebPortalConstants.SCREEN_WIDTH, WebPortalConstants.SCREEN_HEIGHT)
                 .setTimezoneId(WebPortalConstants.TIME_ZONE));

src/main/java/io/swaglabs/portal/qa/constants/WebPortalConstants.java

@@ -1,8 +1,7 @@
 package io.swaglabs.portal.qa.constants;
 
 import com.microsoft.playwright.BrowserType;
-import io.swaglabs.portal.qa.screenshotsmanager.ScreenshotContext;
-import io.swaglabs.portal.qa.screenshotsmanager.ScreenshotsUtils;
+import io.swaglabs.portal.qa.utils.ScreenshotsUtils;
 import io.swaglabs.portal.qa.utils.WebConfigLoader;
 import lombok.AccessLevel;
 import lombok.NoArgsConstructor;
@@ -31,10 +30,8 @@ public final class WebPortalConstants {
     public static final String IMAGE_FORMAT = ".png";
 
     // Browser Type Launch Options Config
-    public static final BrowserType.LaunchOptions BROWSER_LAUNCH_OPTIONS = new BrowserType.LaunchOptions()
-            .setArgs(List.of("--window-position=0,0"));
+    public static final BrowserType.LaunchOptions BROWSER_LAUNCH_OPTIONS = new BrowserType.LaunchOptions();
 
     // SCREENSHOT STRATEGIES
     public static final ScreenshotsUtils SCREENSHOTS_UTILS = ScreenshotsUtils.getInstance();
-    public static final ScreenshotContext FULL_PAGE_SCREENSHOT = SCREENSHOTS_UTILS.getFullPageScreenshotContext();
 }

src/main/java/io/swaglabs/portal/qa/pages/SwagLabsProductPage.java

@@ -18,7 +18,7 @@ public String getProductNameText() {
     public String getProductPriceText() {
         Locator productPrice = locators.getPageLocator(".inventory_details_price");
         String productPriceText = getTextContent(productPrice);
-        WebPortalConstants.SCREENSHOTS_UTILS.takeElementScreenshot(basePage, productPrice, productPriceText);
+        WebPortalConstants.SCREENSHOTS_UTILS.takeElementScreenshot(productPrice, productPriceText);
         return productPriceText;
     }
 
@@ -33,7 +33,7 @@ public boolean isProductAddedToCart() {
 
     public boolean isShoppingCartClicked() {
         Locator shoppingCart = locators.getPageLocator(".shopping_cart_link");
-        WebPortalConstants.SCREENSHOTS_UTILS.takeElementScreenshot(basePage, shoppingCart, "shoppingCart");
+        WebPortalConstants.SCREENSHOTS_UTILS.takeElementScreenshot(shoppingCart, "shoppingCart");
         clickElement(shoppingCart);
         return true;
     }

src/main/java/io/swaglabs/portal/qa/screenshotsmanager/ElementScreenshotStrategy.java

@@ -1,18 +1,17 @@
 package io.swaglabs.portal.qa.screenshotsmanager;
 
 import com.microsoft.playwright.Locator;
-import com.microsoft.playwright.Page;
-import lombok.AllArgsConstructor;
+import lombok.RequiredArgsConstructor;
 
 import java.nio.file.Paths;
 
-@AllArgsConstructor
+@RequiredArgsConstructor
 public class ElementScreenshotStrategy implements ScreenshotStrategy {
 
     private final Locator locator;
 
     @Override
-    public void capture(Page page, String filePath) {
+    public void capture(String filePath) {
         locator.screenshot(new Locator.ScreenshotOptions().setPath(Paths.get(filePath)));
     }
 }

src/main/java/io/swaglabs/portal/qa/screenshotsmanager/FullPageScreenshotStrategy.java

@@ -1,13 +1,17 @@
 package io.swaglabs.portal.qa.screenshotsmanager;
 
 import com.microsoft.playwright.Page;
+import lombok.RequiredArgsConstructor;
 
 import java.nio.file.Paths;
 
+@RequiredArgsConstructor
 public class FullPageScreenshotStrategy implements ScreenshotStrategy {
 
+    private final Page PAGE;
+
     @Override
-    public void capture(Page page, String filePath) {
-        page.screenshot(new Page.ScreenshotOptions().setPath(Paths.get(filePath)).setFullPage(true));
+    public void capture(String filePath) {
+        PAGE.screenshot(new Page.ScreenshotOptions().setPath(Paths.get(filePath)).setFullPage(true));
     }
 }

src/main/java/io/swaglabs/portal/qa/screenshotsmanager/ScreenshotContext.java

@@ -1,17 +1,13 @@
 package io.swaglabs.portal.qa.screenshotsmanager;
 
-import com.microsoft.playwright.Page;
-import lombok.AllArgsConstructor;
+import lombok.RequiredArgsConstructor;
 
-import java.util.Objects;
-
-@AllArgsConstructor
+@RequiredArgsConstructor
 public class ScreenshotContext {
 
-    private ScreenshotStrategy screenshotStrategy;
+    private final ScreenshotStrategy screenshotStrategy;
 
-    public void captureScreenshot(Page page, String filePath) {
-        Objects.requireNonNull(screenshotStrategy, "Screenshot strategy is not set.");
-        screenshotStrategy.capture(page, filePath);
+    public void captureScreenshot(String filePath) {
+        screenshotStrategy.capture(filePath);
     }
 }

src/main/java/io/swaglabs/portal/qa/screenshotsmanager/ScreenshotStrategy.java

@@ -1,8 +1,6 @@
 package io.swaglabs.portal.qa.screenshotsmanager;
 
-import com.microsoft.playwright.Page;
-
 public interface ScreenshotStrategy {
 
-    void capture(Page page, String filePath);
+    void capture(String filePath);
 }

…screenshotsmanager/ScreenshotsUtils.java …bs/portal/qa/utils/ScreenshotsUtils.javasrc/main/java/io/swaglabs/portal/qa/screenshotsmanager/ScreenshotsUtils.java renamed to src/main/java/io/swaglabs/portal/qa/utils/ScreenshotsUtils.java src/main/java/io/swaglabs/portal/qa/screenshotsmanager/ScreenshotsUtils.java renamed to src/main/java/io/swaglabs/portal/qa/utils/ScreenshotsUtils.java

@@ -1,8 +1,11 @@
-package io.swaglabs.portal.qa.screenshotsmanager;
+package io.swaglabs.portal.qa.utils;
 
 import com.microsoft.playwright.Locator;
 import com.microsoft.playwright.Page;
 import io.swaglabs.portal.qa.constants.WebPortalConstants;
+import io.swaglabs.portal.qa.screenshotsmanager.ElementScreenshotStrategy;
+import io.swaglabs.portal.qa.screenshotsmanager.FullPageScreenshotStrategy;
+import io.swaglabs.portal.qa.screenshotsmanager.ScreenshotContext;
 import lombok.AccessLevel;
 import lombok.NoArgsConstructor;
 
@@ -11,9 +14,9 @@
 @NoArgsConstructor(access = AccessLevel.PRIVATE)
 public class ScreenshotsUtils {
 
+    private static ScreenshotsUtils instance;
     private static final String ELEMENT_SCREENSHOT_FILE_LOCATION = WebPortalConstants.SCREENSHOT_FILE_LOCATION
             + "/elements/" + WebPortalConstants.BROWSER + "_" + WebPortalConstants.RUN_MODE + "_Element_";
-    private static ScreenshotsUtils instance;
 
     public static ScreenshotsUtils getInstance() {
         if (instance == null) {
@@ -26,17 +29,14 @@ public static ScreenshotsUtils getInstance() {
         return instance;
     }
 
-    public ScreenshotContext getFullPageScreenshotContext() {
-        return new ScreenshotContext(new FullPageScreenshotStrategy());
-    }
-
-    public ScreenshotContext getElementScreenshotContext(Locator locator) {
-        Objects.requireNonNull(locator, "Locator cannot be null for taking element screenshot");
-        return new ScreenshotContext(new ElementScreenshotStrategy(locator));
+    public ScreenshotContext getFullPageScreenshotContext(Page page) {
+        return new ScreenshotContext(new FullPageScreenshotStrategy(page));
     }
 
-    public void takeElementScreenshot(Page page, Locator locator, String fileName) {
-        getElementScreenshotContext(locator).captureScreenshot(page,
-                ELEMENT_SCREENSHOT_FILE_LOCATION + fileName + WebPortalConstants.IMAGE_FORMAT);
+    public void takeElementScreenshot(Locator locator, String fileName) {
+        Objects.requireNonNull(locator, "Locator cannot be null.");
+        Objects.requireNonNull(fileName, "File name cannot be null.");
+        String filePath = ELEMENT_SCREENSHOT_FILE_LOCATION + fileName + WebPortalConstants.IMAGE_FORMAT;
+        new ScreenshotContext(new ElementScreenshotStrategy(locator)).captureScreenshot(filePath);
     }
 }

src/test/java/io/swaglabs/portal/qa/listeners/WebTestListeners.java

@@ -71,7 +71,7 @@ private void takeScreenshot(ITestResult testResult) {
         String filePath = Paths.get(dirPath, fileName).toString();
         try {
             Files.createDirectories(Paths.get(dirPath));
-            WebPortalConstants.FULL_PAGE_SCREENSHOT.captureScreenshot(currentPage, filePath);
+            WebPortalConstants.SCREENSHOTS_UTILS.getFullPageScreenshotContext(currentPage).captureScreenshot(filePath);
         } catch (IOException e) {
             log.error("Screenshot failed for {}: {}", testName, e.getMessage());
         }