Skip to content

Commit 54c6ebb

Browse files
Created window position constant.
1 parent 1986add commit 54c6ebb

3 files changed

Lines changed: 3 additions & 4 deletions

File tree

src/main/java/io/swaglabs/portal/qa/browsermanager/ChromeBrowser.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ public class ChromeBrowser implements IBrowser {
1313
@Override
1414
public BrowserContext createSession(Playwright playwright, boolean isHeadless) {
1515
BrowserType.LaunchOptions chromeLaunchOptions = WebPortalConstants.BROWSER_LAUNCH_OPTIONS.setHeadless(isHeadless)
16-
.setArgs(List.of("--window-position=0,0"));
16+
.setArgs(List.of(WebPortalConstants.WINDOW_POSITION));
1717
return playwright.chromium().launch(chromeLaunchOptions).newContext(new Browser.NewContextOptions()
1818
.setViewportSize(WebPortalConstants.SCREEN_WIDTH, WebPortalConstants.SCREEN_HEIGHT)
1919
.setTimezoneId(WebPortalConstants.TIME_ZONE));

src/main/java/io/swaglabs/portal/qa/browsermanager/MsEdgeBrowser.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public BrowserContext createSession(Playwright playwright, boolean isHeadless) {
1414
BrowserType.LaunchOptions msedgeLaunchOptions = WebPortalConstants.BROWSER_LAUNCH_OPTIONS
1515
.setHeadless(isHeadless)
1616
.setChannel(BrowserName.MS_EDGE.getBrowserType())
17-
.setArgs(List.of("--window-position=0,0"));
17+
.setArgs(List.of(WebPortalConstants.WINDOW_POSITION));
1818
return playwright.chromium().launch(msedgeLaunchOptions).newContext(new Browser.NewContextOptions()
1919
.setViewportSize(WebPortalConstants.SCREEN_WIDTH, WebPortalConstants.SCREEN_HEIGHT)
2020
.setTimezoneId(WebPortalConstants.TIME_ZONE));

src/main/java/io/swaglabs/portal/qa/constants/WebPortalConstants.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66
import lombok.AccessLevel;
77
import lombok.NoArgsConstructor;
88

9-
import java.util.List;
10-
119
@NoArgsConstructor(access = AccessLevel.PRIVATE)
1210
public final class WebPortalConstants {
1311

@@ -25,6 +23,7 @@ public final class WebPortalConstants {
2523
// Web Browser resolution
2624
public static final int SCREEN_WIDTH = 1920;
2725
public static final int SCREEN_HEIGHT = 1080;
26+
public static final String WINDOW_POSITION = "--window-position=0,0";
2827

2928
public static final String SCREENSHOT_FILE_LOCATION = "./target/screenshots/";
3029
public static final String IMAGE_FORMAT = ".png";

0 commit comments

Comments
 (0)