Skip to content

Commit b4a29f4

Browse files
Renamed MSEDGE to EDGE.
1 parent d8f0fc9 commit b4a29f4

5 files changed

Lines changed: 7 additions & 7 deletions

File tree

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
<dependency>
2121
<groupId>com.microsoft.playwright</groupId>
2222
<artifactId>playwright</artifactId>
23-
<version>1.51.0</version>
23+
<version>1.55.0</version>
2424
</dependency>
2525
<dependency>
2626
<groupId>org.testng</groupId>

src/main/java/io/swaglabs/portal/qa/browsermanager/BrowserFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ public class BrowserFactory {
77
public IBrowser createBrowser() {
88
return switch (BrowserName.fromConfigValue(WebPortalConstants.BROWSER)) {
99
case CHROME -> new ChromeBrowser();
10-
case MS_EDGE -> new MsEdgeBrowser();
10+
case EDGE -> new EdgeBrowser();
1111
case FIREFOX -> new FirefoxBrowser();
1212
case WEBKIT -> new WebkitBrowser();
1313
};

src/main/java/io/swaglabs/portal/qa/browsermanager/BrowserName.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
public enum BrowserName {
1313

1414
CHROME("chrome"),
15-
MS_EDGE("msedge"),
15+
EDGE("msedge"),
1616
FIREFOX("firefox"),
1717
WEBKIT("webkit");
1818

@@ -21,7 +21,7 @@ public enum BrowserName {
2121
public static BrowserName fromConfigValue(String browserName) {
2222
Objects.requireNonNull(browserName, "Browser name cannot be null");
2323
return Arrays.stream(BrowserName.values())
24-
.filter(browserType -> browserType.getBrowserType().equalsIgnoreCase(browserName))
24+
.filter(browser -> browser.getBrowserType().equalsIgnoreCase(browserName))
2525
.findFirst().orElseThrow(() -> new WebUtilsException("Unknown browser: " + browserName));
2626
}
2727
}

src/main/java/io/swaglabs/portal/qa/browsermanager/MsEdgeBrowser.java renamed to src/main/java/io/swaglabs/portal/qa/browsermanager/EdgeBrowser.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@
88

99
import java.util.List;
1010

11-
public class MsEdgeBrowser implements IBrowser {
11+
public class EdgeBrowser implements IBrowser {
1212
@Override
1313
public BrowserContext createSession(Playwright playwright, boolean isHeadless) {
1414
BrowserType.LaunchOptions msedgeLaunchOptions = WebPortalConstants.BROWSER_LAUNCH_OPTIONS
1515
.setHeadless(isHeadless)
16-
.setChannel(BrowserName.MS_EDGE.getBrowserType())
16+
.setChannel(BrowserName.EDGE.getBrowserType())
1717
.setArgs(List.of(WebPortalConstants.WINDOW_POSITION));
1818
return playwright.chromium().launch(msedgeLaunchOptions).newContext(new Browser.NewContextOptions()
1919
.setViewportSize(WebPortalConstants.SCREEN_WIDTH, WebPortalConstants.SCREEN_HEIGHT)

src/test/java/io/swaglabs/portal/qa/commons/WebBaseTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,6 @@ public void destroy() {
7979

8080
private boolean isChromiumBrowser() {
8181
String browserName = WebPortalConstants.BROWSER;
82-
return (browserName.equalsIgnoreCase(BrowserName.CHROME.getBrowserType()) || browserName.equalsIgnoreCase(BrowserName.MS_EDGE.getBrowserType()));
82+
return (browserName.equalsIgnoreCase(BrowserName.CHROME.getBrowserType()) || browserName.equalsIgnoreCase(BrowserName.EDGE.getBrowserType()));
8383
}
8484
}

0 commit comments

Comments
 (0)