Skip to content

Commit d8f0fc9

Browse files
Merge pull request #53 from iamcharankumar/fb_small_refactor
Used Required Args constructors.
2 parents 3386632 + 12d37b3 commit d8f0fc9

6 files changed

Lines changed: 13 additions & 12 deletions

File tree

src/main/java/io/swaglabs/portal/qa/browsermanager/BrowserFactory.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@ public class BrowserFactory {
66

77
public IBrowser createBrowser() {
88
return switch (BrowserName.fromConfigValue(WebPortalConstants.BROWSER)) {
9+
case CHROME -> new ChromeBrowser();
10+
case MS_EDGE -> new MsEdgeBrowser();
911
case FIREFOX -> new FirefoxBrowser();
1012
case WEBKIT -> new WebkitBrowser();
11-
case MS_EDGE -> new MsEdgeBrowser();
12-
default -> new ChromeBrowser();
1313
};
1414
}
1515
}

src/main/java/io/swaglabs/portal/qa/browsermanager/BrowserName.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
11
package io.swaglabs.portal.qa.browsermanager;
22

33
import io.swaglabs.portal.qa.exceptions.WebUtilsException;
4-
import lombok.AllArgsConstructor;
54
import lombok.Getter;
5+
import lombok.RequiredArgsConstructor;
66

77
import java.util.Arrays;
88
import java.util.Objects;
99

1010
@Getter
11-
@AllArgsConstructor
11+
@RequiredArgsConstructor
1212
public enum BrowserName {
1313

1414
CHROME("chrome"),
15-
FIREFOX("firefox"),
1615
MS_EDGE("msedge"),
16+
FIREFOX("firefox"),
1717
WEBKIT("webkit");
1818

1919
private final String browserType;

src/main/java/io/swaglabs/portal/qa/browsermanager/ChromeBrowser.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ public class ChromeBrowser implements IBrowser {
1313
@Override
1414
public BrowserContext createSession(Playwright playwright, boolean isHeadless) {
1515
BrowserType.LaunchOptions chromeLaunchOptions = WebPortalConstants.BROWSER_LAUNCH_OPTIONS.setHeadless(isHeadless)
16-
.setArgs(List.of(WebPortalConstants.WINDOW_POSITION));
16+
.setArgs(List.of(WebPortalConstants.WINDOW_POSITION))
17+
.setChannel(BrowserName.CHROME.getBrowserType());
1718
return playwright.chromium().launch(chromeLaunchOptions).newContext(new Browser.NewContextOptions()
1819
.setViewportSize(WebPortalConstants.SCREEN_WIDTH, WebPortalConstants.SCREEN_HEIGHT)
1920
.setTimezoneId(WebPortalConstants.TIME_ZONE));

src/main/java/io/swaglabs/portal/qa/cdp/CdpCommands.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
package io.swaglabs.portal.qa.cdp;
22

3-
import lombok.AllArgsConstructor;
43
import lombok.Getter;
4+
import lombok.RequiredArgsConstructor;
55

66
@Getter
7-
@AllArgsConstructor
7+
@RequiredArgsConstructor
88
public enum CdpCommands {
99

1010
NETWORK_ENABLE("Network.enable"),

src/main/java/io/swaglabs/portal/qa/cdp/CdpEvents.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
package io.swaglabs.portal.qa.cdp;
22

3-
import lombok.AllArgsConstructor;
43
import lombok.Getter;
4+
import lombok.RequiredArgsConstructor;
55

66
@Getter
7-
@AllArgsConstructor
7+
@RequiredArgsConstructor
88
public enum CdpEvents {
99

1010
NETWORK_REQUEST_WILL_BE_SENT("Network.requestWillBeSent"),

src/main/java/io/swaglabs/portal/qa/constants/KeyboardEvents.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
package io.swaglabs.portal.qa.constants;
22

3-
import lombok.AllArgsConstructor;
43
import lombok.Getter;
4+
import lombok.RequiredArgsConstructor;
55

66
@Getter
7-
@AllArgsConstructor
7+
@RequiredArgsConstructor
88
public enum KeyboardEvents {
99

1010
ENTER("Enter"),

0 commit comments

Comments
 (0)