Skip to content

Implemented null handling. #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamcharankumar merged 1 commit into from
Aug 15, 2025
Merged

Implemented null handling. #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/io/swaglabs/portal/qa/browsermanager/BrowserFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
public class BrowserFactory {

public IBrowser createBrowser() {
return switch (BrowserName.fromString(WebPortalConstants.BROWSER)) {
return switch (BrowserName.fromConfigValue(WebPortalConstants.BROWSER)) {
case FIREFOX -> new FirefoxBrowser();
case WEBKIT -> new WebkitBrowser();
case MS_EDGE -> new MsEdgeBrowser();
Expand Down
1 change: 1 addition & 0 deletions src/main/java/io/swaglabs/portal/qa/browsermanager/BrowserManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ public class BrowserManager implements IBrowserManager<Page> {

@Override
public Page getBrowserPage(Playwright playwright) {
Objects.requireNonNull(playwright, "Playwright instance is null in Browser Manager!");
boolean isHeadless = "headless".equals(WebPortalConstants.RUN_MODE);
BrowserContext browserContext = new BrowserFactory().createBrowser().createSession(playwright, isHeadless);
Objects.requireNonNull(browserContext, "Playwright Browser Context is null!");
Expand Down
4 changes: 3 additions & 1 deletion src/main/java/io/swaglabs/portal/qa/browsermanager/BrowserName.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import lombok.Getter;

import java.util.Arrays;
import java.util.Objects;

@Getter
@AllArgsConstructor
Expand All @@ -17,7 +18,8 @@ public enum BrowserName {

private final String browserType;

public static BrowserName fromString(String browserName) {
public static BrowserName fromConfigValue(String browserName) {
Objects.requireNonNull(browserName, "Browser name cannot be null");
return Arrays.stream(BrowserName.values())
.filter(browserType -> browserType.getBrowserType().equalsIgnoreCase(browserName))
.findFirst().orElseThrow(() -> new WebUtilsException("Unknown browser: " + browserName));
Expand Down