Merge fix/nova-435-resolve-method-signature: Nova 4.35.x compatibility fix

Fixes method signature incompatibility with Laravel Nova 4.35.x
by removing strict type hints from resolve() and resolveForDisplay() methods.

Closes #1

Author: iamgerwin

CHANGELOG.md

@@ -2,6 +2,22 @@
 
 All notable changes to `nova-dependency-container` will be documented in this file.
 
+## [1.0.4] - 2025-11-25
+
+### Fixed
+- Fixed Nova 4.35.x compatibility issue with `resolveForDisplay` method signature mismatch ([#1](https://github.com/iamgerwin/nova-dependency-container/issues/1))
+- Fixed `resolve` method signature to match parent `Laravel\Nova\Fields\Field` class
+- Updated `Stubs/Field.php` method signatures to align with Nova's actual implementation
+
+### Changed
+- Removed strict type hints from `resolve($resource, $attribute = null)` method for Nova compatibility
+- Removed strict type hints from `resolveForDisplay($resource, $attribute = null)` method for Nova compatibility
+- Updated `MockField` test mock to use compatible method signatures
+
+### Added
+- Added comprehensive tests for method signature compatibility using PHP Reflection API
+- Added tests for method invocation with various argument types
+
 ## [1.0.3] - 2025-09-26
 
 ### Added

README.md

@@ -14,7 +14,7 @@ A Laravel Nova field container allowing fields to depend on other field values.
 - **Conditional Field Display**: Show/hide fields based on other field values
 - **Multiple Dependency Types**: Support for various comparison operators
 - **Complex Logic**: Chain multiple conditions together
-- **Nova 4 & 5 Compatible**: Works with Laravel Nova 4.x and 5.x (tested with Nova 5.7.5)
+- **Nova 4 & 5 Compatible**: Works with Laravel Nova 4.x and 5.x (tested with Nova 4.35.x and Nova 5.7.5)
 - **Laravel 12 Ready**: Full support for Laravel 11.x and 12.x
 - **PHP 8.3 Support**: Modern PHP features and type safety
 - **Fully Tested**: Comprehensive test coverage with Pest

composer.json

@@ -1,6 +1,6 @@
 {
     "name": "iamgerwin/nova-dependency-container",
-    "version": "1.0.3",
+    "version": "1.0.4",
     "description": "A Laravel Nova 4 and 5 field container allowing to depend on other fields values",
     "keywords": [
         "laravel",

src/NovaDependencyContainer.php

@@ -187,7 +187,7 @@ public function fill($request, $model): void
         }
     }
 
-    public function resolve($resource, ?string $attribute = null): void
+    public function resolve($resource, $attribute = null)
     {
         foreach ($this->fields as $field) {
             if ($field instanceof Field) {
@@ -196,7 +196,7 @@ public function resolve($resource, ?string $attribute = null): void
         }
     }
 
-    public function resolveForDisplay($resource, ?string $attribute = null): void
+    public function resolveForDisplay($resource, $attribute = null)
     {
         foreach ($this->fields as $field) {
             if ($field instanceof Field) {

src/Stubs/Field.php

@@ -65,7 +65,7 @@ public function fill($request, $model)
         return function () {};
     }
 
-    public function resolve($resource, ?string $attribute = null): void {}
+    public function resolve($resource, $attribute = null) {}
 
-    public function resolveForDisplay($resource, ?string $attribute = null): void {}
+    public function resolveForDisplay($resource, $attribute = null) {}
 }

tests/Mocks/MockField.php

@@ -49,7 +49,7 @@ public function fill($request, $model)
         return function () {};
     }
 
-    public function resolve($resource, ?string $attribute = null): void {}
+    public function resolve($resource, $attribute = null) {}
 
-    public function resolveForDisplay($resource, ?string $attribute = null): void {}
+    public function resolveForDisplay($resource, $attribute = null) {}
 }

tests/Unit/NovaDependencyContainerTest.php

@@ -169,3 +169,85 @@ class Text extends MockField
 
     expect($container->showOnDetail)->toBeFalse();
 });
+
+it('has resolve method signature compatible with Nova Field class', function () {
+    $reflection = new ReflectionMethod(NovaDependencyContainer::class, 'resolve');
+
+    // Method should have no return type (matches Nova Field parent class)
+    expect($reflection->hasReturnType())->toBeFalse();
+
+    // Method should have two parameters
+    $parameters = $reflection->getParameters();
+    expect($parameters)->toHaveCount(2);
+
+    // First parameter: $resource (no type hint)
+    expect($parameters[0]->getName())->toBe('resource');
+    expect($parameters[0]->hasType())->toBeFalse();
+
+    // Second parameter: $attribute (no type hint, has default null)
+    expect($parameters[1]->getName())->toBe('attribute');
+    expect($parameters[1]->hasType())->toBeFalse();
+    expect($parameters[1]->isDefaultValueAvailable())->toBeTrue();
+    expect($parameters[1]->getDefaultValue())->toBeNull();
+});
+
+it('has resolveForDisplay method signature compatible with Nova Field class', function () {
+    $reflection = new ReflectionMethod(NovaDependencyContainer::class, 'resolveForDisplay');
+
+    // Method should have no return type (matches Nova Field parent class)
+    expect($reflection->hasReturnType())->toBeFalse();
+
+    // Method should have two parameters
+    $parameters = $reflection->getParameters();
+    expect($parameters)->toHaveCount(2);
+
+    // First parameter: $resource (no type hint)
+    expect($parameters[0]->getName())->toBe('resource');
+    expect($parameters[0]->hasType())->toBeFalse();
+
+    // Second parameter: $attribute (no type hint, has default null)
+    expect($parameters[1]->getName())->toBe('attribute');
+    expect($parameters[1]->hasType())->toBeFalse();
+    expect($parameters[1]->isDefaultValueAvailable())->toBeTrue();
+    expect($parameters[1]->getDefaultValue())->toBeNull();
+});
+
+it('can call resolve method with various argument types', function () {
+    $container = NovaDependencyContainer::make([
+        Text::make('Field 1'),
+    ]);
+
+    $resource = new stdClass;
+    $resource->field_1 = 'test value';
+
+    // Should work with null attribute (default)
+    $container->resolve($resource);
+
+    // Should work with string attribute
+    $container->resolve($resource, 'field_1');
+
+    // Should work with null explicitly passed
+    $container->resolve($resource, null);
+
+    expect(true)->toBeTrue();
+});
+
+it('can call resolveForDisplay method with various argument types', function () {
+    $container = NovaDependencyContainer::make([
+        Text::make('Field 1'),
+    ]);
+
+    $resource = new stdClass;
+    $resource->field_1 = 'test value';
+
+    // Should work with null attribute (default)
+    $container->resolveForDisplay($resource);
+
+    // Should work with string attribute
+    $container->resolveForDisplay($resource, 'field_1');
+
+    // Should work with null explicitly passed
+    $container->resolveForDisplay($resource, null);
+
+    expect(true)->toBeTrue();
+});