fix: Support nova-flexible-content random key attribute format (#4)#10
Merged
Conversation
Updated regex patterns in extractPrefixFromAttribute() and extractBaseAttribute() to handle random alphanumeric keys like 'cSkn6uKpVHMkMLmI__' instead of just numeric index patterns like 'overlay_items__0__' Added Pattern 3: ^([a-zA-Z0-9]+__) for random key format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed regex patterns to support nova-flexible-content's random key attribute format.
Root Cause
The package was only matching numeric index patterns like
overlay_items__0__but nova-flexible-content uses random alphanumeric keys likecSkn6uKpVHMkMLmI__.From the debug logs:
Solution
Added Pattern 3 to handle random key format:
extractPrefixFromAttribute(): Added^([a-zA-Z0-9]+__)patternextractBaseAttribute(): Added^[a-zA-Z0-9]+__(.+)$patternFiles Changed
resources/js/components/FormField.vueresources/js/components/DetailField.vuedist/js/field.jsFixes #4