fix: Add DOM-based watching for Flexible fields (#4)#11
Merged
Conversation
Nova's global field-changed events are not emitted by fields inside nova-flexible-content layouts. Added fallback DOM watching: - setupDOMWatching(): Listen for native change/input events - loadInitialValuesFromDOM(): Get values directly from DOM elements - findFlexibleContainer(): Locate the Flexible layout wrapper - handleDOMChange(): Process native DOM events - MutationObserver: Detect dynamically added elements - Proper cleanup on unmount
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nova's global
field-changedevents are not emitted by fields inside nova-flexible-content layouts. This PR adds DOM-based watching as a fallback.Root Cause
From the debug logs, we can see that:
field-changedevents are received when changing the Type fieldThis is because fields inside Flexible layouts don't emit to Nova's global event bus.
Solution
Added DOM-based watching to detect field changes directly:
setupDOMWatching(): Attacheschangeandinputevent listeners to form elementsloadInitialValuesFromDOM(): Gets field values directly from DOM elements at mount timefindFlexibleContainer(): Locates the Flexible layout wrapper elementhandleDOMChange(): Processes native DOM change eventsMutationObserver: Detects dynamically added elementsFiles Changed
resources/js/components/FormField.vuedist/js/field.jsFixes #4