fix: Improved Flexible field context detection v2 (#4)#6
Merged
Conversation
…approach Key improvements: - Add detectFlexibleContextOnMount() for early context detection - Detect context from container attribute, child fields, parent components, and DOM - Only cache base attribute values when context matches event prefix - Filter events strictly once context is detected - Claim context only from relevant events (matching dependency fields) This fixes cross-group contamination in multi-group Flexible layouts where the first event would incorrectly set context for all containers. Fixes #4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the remaining issues with Flexible field support where the dependency container was still not working correctly inside Flexible layouts.
Root Cause
The previous fix had a critical bug: when multiple NovaDependencyContainer instances exist in different Flexible groups, the first field-changed event would set the context for ALL containers, causing cross-group contamination.
Solution
Implemented a multi-method context detection approach:
1. Early Context Detection (at mount time)
2. Improved Event Handling
3. Prevents Cross-Group Contamination
Files Changed
resources/js/components/FormField.vue- Main improvementsresources/js/components/DetailField.vue- Same detection improvementsTest Plan
Related Issue
Fixes #4