fix: Include compiled dist assets in package (#4)#7
Merged
Conversation
Built production assets with npm run prod: - dist/js/field.js (21.5 KiB) - dist/css/field.css (237 bytes)
- Removed /dist from gitignore so compiled assets are included in package - Added PR.md to gitignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Vue components were not working because the compiled
/distfolder was gitignored, preventing the built assets from being included in the package distribution.Root Cause
The
.gitignorefile contained/distwhich excluded the compiled Vue components from being committed and distributed via Composer.Solution
/distfrom .gitignorenpm run prodFiles Changed
dist/js/field.jsdist/css/field.cssdist/mix-manifest.json.gitignoreCHANGELOG.mdcomposer.jsondocs/flexible-field-support.mdTest Plan
Fixes #4