fix: resolve #894 — Feature: add locale format string to localeData or somewhere else#3034
Open
tang-vu wants to merge 1 commit into
Open
Conversation
…Data or somewhere else Fixes iamkun#894 Signed-off-by: Tang Vu <145498528+tang-vu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: resolve #894 — Feature: add locale format string to localeData or somewhere else
Problem
Severity:
Low| File:src/plugin/localeData/index.jsCurrently, there is no public, documented way to retrieve the localized format strings (like 'L', 'LL', 'LT', etc.) for a specific locale without accessing internal properties like
$locale().formats. This enhancement adds thelongDateFormatmethod to thelocaleDataplugin, providing a Moment.js-compatible API to retrieve these format strings. This is useful for UI components that need to know the date format pattern (e.g., 'MM/DD/YYYY') based on the user's current locale.Solution
Update the
localeDataplugin to include thelongDateFormatmethod in the object returned bydayjs().localeData()anddayjs.localeData().Changes
src/plugin/localeData/index.js(modified)Testing
Generated by ContribAI v5.7.1