fix: Remove ExpectNonEmptyPlan from network data source tests and add zone data source configuration

Author: ianc769

cloudstack/data_source_cloudstack_network_test.go

@@ -42,7 +42,6 @@ func TestAccNetworkDataSource_basic(t *testing.T) {
 					resource.TestCheckResourceAttrPair(datasourceName, "gateway", resourceName, "gateway"),
 					resource.TestCheckResourceAttr(datasourceName, "network_offering_name", "DefaultIsolatedNetworkOfferingWithSourceNatService"),
 				),
-				ExpectNonEmptyPlan: true,
 			},
 		},
 	})
@@ -62,7 +61,6 @@ func TestAccNetworkDataSource_filterByZone(t *testing.T) {
 					resource.TestCheckResourceAttrPair(datasourceName, "name", resourceName, "name"),
 					resource.TestCheckResourceAttr(datasourceName, "zone_name", "Sandbox-simulator"),
 				),
-				ExpectNonEmptyPlan: true,
 			},
 		},
 	})
@@ -83,7 +81,6 @@ func TestAccNetworkDataSource_vpcNetwork(t *testing.T) {
 					resource.TestCheckResourceAttrPair(datasourceName, "vpc_id", resourceName, "vpc_id"),
 					resource.TestCheckResourceAttr(datasourceName, "vpc_name", "test-vpc-network"),
 				),
-				ExpectNonEmptyPlan: true,
 			},
 		},
 	})
@@ -116,6 +113,13 @@ output "network-output" {
 `
 
 const testNetworkDataSourceConfig_filterByZone = `
+data "cloudstack_zone" "zone" {
+  filter {
+    name  = "name"
+    value = "Sandbox-simulator"
+  }
+}
+
 resource "cloudstack_network" "network-resource" {
   name             = "test-network-zone"
   display_text     = "Test Network with Zone Filter"
@@ -125,7 +129,7 @@ resource "cloudstack_network" "network-resource" {
 }
 
 data "cloudstack_network" "network-data-source-zone" {
-  zone_id = cloudstack_network.network-resource.zone
+  zone_id = data.cloudstack_zone.zone.id
   
   filter {
     name  = "name"
@@ -146,7 +150,7 @@ const testNetworkDataSourceConfig_vpcNetwork = `
 resource "cloudstack_vpc" "vpc-resource" {
   name         = "test-vpc-network"
   cidr         = "10.2.0.0/16"
-  vpc_offering = "Default VPC Offering"
+  vpc_offering = "Default VPC offering"
   zone         = "Sandbox-simulator"
 }