Feat/diskann macos - #6
Open
iaojnh wants to merge 62 commits into
Open
Conversation
… into refactor/diskann_dlopen
… into refactor/diskann_dlopen
… into refactor/diskann_dlopen
… into refactor/diskann_dlopen
The index_group_by_test uses DiskAnn indexes (guarded by #if DISKANN_SUPPORTED) to verify that group_by search is rejected for unsupported index types. However, the CMakeLists.txt for tests/core/interface/ did not link core_knn_diskann, causing the DiskAnn factory to not be registered at runtime. This resulted in IndexFactory::CreateAndInitIndex returning nullptr for DiskAnn indexes, failing the test assertion. Add core_knn_diskann to the LIBS list, consistent with how other test directories (tests/db/, tests/db/index/, tests/core/algorithm/diskann/) handle DiskAnn linking.
# Conflicts: # .github/workflows/03-macos-linux-build.yml # .github/workflows/nightly_coverage.yml # CMakeLists.txt # examples/c++/CMakeLists.txt # python/tests/detail/fixture_helper.py # python/tests/test_collection_diskann.py # python/zvec/__init__.py # src/binding/python/model/common/python_config.cc # src/core/CMakeLists.txt # src/core/algorithm/diskann/CMakeLists.txt # src/core/algorithm/diskann/diskann_builder.cc # src/core/algorithm/diskann/diskann_file_reader.cc # src/core/algorithm/diskann/diskann_file_reader.h # src/core/algorithm/diskann/diskann_searcher.cc # src/core/algorithm/diskann/diskann_streamer.cc # src/db/index/common/schema.cc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.