You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Switch test assertions to canonical commissionAndFees, drop deprecation warnings
The protobuf-side tests asserted on the legacy ``.commission``
attribute and ``commission=`` kwarg in ~15 places, each producing a
``DeprecationWarning`` on every test run. The legacy alias is
documented behaviour through v4.0 — the warnings are noise, not
signal — so the tests should use the canonical
``.commissionAndFees`` name everywhere except where the deprecation
alias itself is the contract under test.
Changes:
* Switch all assertions / constructor kwargs / handler-captured
reads from ``.commission`` / ``commission=`` to
``.commissionAndFees`` / ``commissionAndFees=`` across
``test_proto_audit_regressions.py``,
``test_proto_decoder_dispatch.py``,
``test_proto_orders.py``,
``test_round6_cross_handler_invariants.py``.
* Two tests in ``test_proto_orders.py`` specifically exercise the
rename / deprecation alias surface
(``test_create_order_state_renames_commission_and_fees_to_commission``,
``test_create_commission_report_renames_fields``). Those keep the
legacy ``.commission`` access and gain
``@pytest.mark.filterwarnings("ignore::DeprecationWarning")`` so
the alias contract stays pinned without polluting the warning
stream.
Net: 1001 owned tests still pass; the DeprecationWarning chatter is
gone from the test output.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
0 commit comments