Fixing Error in fetching ContractDetail when strikes below 1 where entered

Author: Hartmut Bischoff

lib/models/ib/contract.rb

@@ -136,13 +136,15 @@ def default_attributes  # :nodoc:
 
     def serialize *fields  # :nodoc:
       print_default = ->(field, default="") { field.blank? ? default : field }
-      print_not_zero = ->(field, default="") { field.to_i.zero? ? default : field }
+			## Non numeric entries are passed untouched, only 0 is converted to the default value
+			## Thus: a Zero-Strike-Option  has to be defined with  «strike: "0"»
+      print_not_zero = ->(field, default="") { field.is_a?(Numeric) && field.zero? ? default : field }
       [(con_id.present? && !con_id.is_a?(Symbol) && con_id.to_i > 0 ? con_id : ""),
        print_default[symbol],
        print_default[self[:sec_type]],
        ( fields.include?(:option) ?
        [ print_default[expiry], 
-				 print_not_zero[strike], 
+				 print_default[strike], 
 				 print_default[self[:right]], 
 				 print_default[multiplier]] : nil ),
        print_default[exchange],

spec/contract_helper.rb

@@ -26,7 +26,7 @@ def request_con_id  sample: SAMPLE
 end
 
 RSpec.shared_examples 'a complete Contract Object' do 
-	subject{ the_contract }
+#	subject{ the_contract }
 	it_behaves_like 'a valid Contract Object'
   it { is_expected.to be_an IB::Contract }
 	its( :contract_detail ){ is_expected.to be_a  IB::ContractDetail }

spec/ib/messages/incoming/contract_data_spec.rb

@@ -4,29 +4,41 @@
 
 RSpec.describe IB::Messages::Incoming::ContractData do
 
+	before(:all) do
+		  establish_connection
+	end
+
+	after(:all) { close_connection }
+
   context IB::Stock  do
     before(:all) do
-		  establish_connection
       ib = IB::Connection.current
-			ib.send_message :RequestContractDetails, contract: IB::Contract.new( sec_type: 'STK', symbol: 'GE', currency: 'USD', exchange:'SMART' )
+			ib.send_message :RequestContractDetails, contract: IB::Stock.new( symbol: 'GE', currency: 'USD', exchange:'SMART' )
       ib.wait_for :ContractDetailsEnd
     end
 
-    after(:all) { close_connection }
+		after(:all){ IB::Connection.current.clear_received :ContractData }
+
 
 #		it_behaves_like 'ContractData Message' do
 #			let( :the_message ){ IB::Connection.current.received[:ContractData].first  }  
 #		end
+		context "Basics" do 
+			subject{  IB::Connection.current.received[:ContractData].contract.last }
 
-		it "inspects" do  # debugging
- 		ib = IB::Connection.current
-			contract =  ib.received[:ContractData].contract.last
-			contract_details =  ib.received[:ContractData].contract_details.last
-
-			puts contract.inspect
-			puts contract_details.inspect
+			it_behaves_like 'a complete Contract Object'
+			its( :sec_type ){is_expected.to eq :stock}
+			its( :symbol ){is_expected.to eq 'GE'}
+			its( :con_id ){is_expected.to eq 7516}
 		end
 
+	  context "received a single contract" do
+			subject{ IB::Connection.current.received[:ContractData]  }
+			it{ is_expected.to be_a Array }
+			its(:size){is_expected.to eq 1 }
+		end
 	end
+
+
 end # describe IB::Messages:Incoming