chore: fix phpstan level 1 issues

Author: dannyvankooten

phpstan.neon.dist

@@ -1,5 +1,5 @@
 parameters:
-    level: 0
+    level: 1
     paths:
       - boxzilla.php
       - autoload.php

src/admin/views/metaboxes/box-appearance-controls.php

@@ -1,4 +1,12 @@
-<?php defined('ABSPATH') or exit; ?>
+<?php defined('ABSPATH') or exit;
+
+/**
+ * Box Appearance Controls
+ *
+ * @var \Boxzilla\Box $box
+ * @var array $opts
+ */
+?>
 <div id="notice-notinymce" class="error" style="display: none;"><p><?php esc_html_e('For the best experience when styling your box, please use the default WordPress visual editor.', 'boxzilla'); ?></p></div>
 
 <table class="form-table">

src/admin/views/settings.php

@@ -1,4 +1,11 @@
-<?php defined('ABSPATH') or exit; ?>
+<?php defined('ABSPATH') or exit;
+
+/**
+ * Settings page
+ *
+ * @var array $opts
+ */
+?>
 <div class="wrap" id="boxzilla-admin" class="boxzilla-settings">
 
     <div class="boxzilla-row">

src/default-actions.php

@@ -7,7 +7,7 @@
 // Register custom post type
 add_action(
     'init',
-    function () use ($boxzilla) {
+    function () {
         $args = [
             'public'          => false,
             'labels'          => [

src/licensing/class-license-manager.php

@@ -2,10 +2,6 @@
 
 namespace Boxzilla\Licensing;
 
-use Boxzilla\Admin\Notices;
-use Boxzilla\Collection;
-use Exception;
-
 class LicenseManager
 {
     /**
@@ -190,6 +186,8 @@ protected function activate_license()
     public function show_license_form()
     {
         $license = $this->license;
+        $extensions = $this->extensions;
+        $notices = $this->notices;
         require __DIR__ . '/views/license-form.php';
     }
 }

src/licensing/class-update-manager.php

@@ -111,7 +111,7 @@ public function get_plugin_info($result, $action = '', $args = null)
     }
 
     /**
-     * @param object $updates
+     * @param null|object $updates
      * @return object
      */
     public function add_updates($updates)

src/licensing/views/license-form.php

@@ -1,8 +1,13 @@
 <?php
+
 // prevent direct file access
 defined('ABSPATH') or exit;
 
-/** @var Boxzilla\Licensing\License $license */
+/**
+ * @var Boxzilla\Licensing\License $license
+ * @var array $notices
+ * @var array $extensions
+ */
 ?>
 
 <h2><?php esc_html_e('License & Plugin Updates', 'boxzilla'); ?></h2>
@@ -16,7 +21,7 @@
         </p>
         <ul class="ul-square">
             <?php
-            foreach ($this->extensions as $p) {
+            foreach ($extensions as $p) {
                 echo '<li>', esc_html($p->name()), '</li>';
             }
             ?>
@@ -29,15 +34,11 @@
 }
 ?>
 
-<?php
-foreach ($this->notices as $notice) {
-    ?>
-    <div class="notice notice-<?php echo $notice['type']; ?> inline">
-        <p><?php echo $notice['message']; ?></p>
-    </div>
-    <?php
-}
-?>
+<?php foreach ($notices as $notice) { ?>
+<div class="notice notice-<?php echo esc_attr($notice['type']); ?> inline">
+    <p><?php echo $notice['message']; ?></p>
+</div>
+<?php } ?>
 
 <form method="post">
     <table class="form-table">
@@ -49,12 +50,12 @@
                     size="40"
                     name="boxzilla_license_key"
                     placeholder="<?php esc_attr_e('Enter your license key..', 'boxzilla'); ?>"
-                    value="<?php echo esc_attr($this->license->key); ?>"
-                    <?php if ($this->license->activated) {
+                    value="<?php echo esc_attr($license->key); ?>"
+                    <?php if ($license->activated) {
                         echo 'readonly';
                     } ?>
                 />
-                <input class="button" type="submit" name="action" value="<?php echo ( $this->license->activated ) ? 'deactivate' : 'activate'; ?>" />
+                <input class="button" type="submit" name="action" value="<?php echo $license->activated ? 'deactivate' : 'activate'; ?>" />
                 <p class="help">
                     <?php
                     esc_html_e('The license key received when purchasing your premium Boxzilla plan.', 'bozilla');
@@ -80,10 +81,6 @@
             </td>
         </tr>
     </table>
-
-
-
-
     <p>
         <input type="submit" class="button button-primary" name="action" value="<?php esc_attr_e('Save Changes', 'boxzilla'); ?>" />
     </p>