chore: fix phpstan level 0 issues

Author: dannyvankooten

.github/workflows/php-run-tests.yml

@@ -1,4 +1,4 @@
-name: Check PHP syntax
+name: Lint, analyse and test on highest supported PHP version
 
 on: [ push, pull_request ]
 

boxzilla.php

@@ -57,10 +57,10 @@ function () {
         require __DIR__ . '/src/default-filters.php';
         require __DIR__ . '/src/default-actions.php';
 
-        if (defined('DOING_AJAX') && DOING_AJAX) {
+        if (wp_doing_ajax()) {
             $boxzilla['filter.autocomplete']->init();
             $boxzilla['admin.menu']->init();
-        } elseif (defined('DOING_CRON') && DOING_CRON) {
+        } elseif (wp_doing_cron()) {
             $boxzilla['license_poller']->init();
         } elseif (is_admin()) {
             $boxzilla['admin']->init();
@@ -75,7 +75,7 @@ function () use ($boxzilla) {
         }
 
         // license manager
-        if (is_admin() || ( defined('DOING_CRON') && DOING_CRON ) || ( defined('WP_CLI') && WP_CLI )) {
+        if (is_admin() || wp_doing_cron() || ( defined('WP_CLI') && WP_CLI )) {
             $boxzilla['license_manager']->init();
 
             if (count($boxzilla->plugins) > 0) {

src/admin/class-admin.php

@@ -145,8 +145,6 @@ public function notices()
 
     /**
      * Checks current version against stored version & runs necessary update routines.
-     *
-     * @return bool
      */
     protected function run_migrations()
     {
@@ -156,7 +154,7 @@ protected function run_migrations()
         $current_version  = $this->plugin->version();
 
         if (version_compare($current_version, $previous_version, '<=')) {
-            return false;
+            return;
         }
 
         $upgrade_routines = new Migrations($previous_version, $current_version, __DIR__ . '/migrations');
@@ -381,13 +379,11 @@ public function load_assets()
      * Register meta boxes
      *
      * @param string $post_type
-     *
-     * @return bool
      */
     public function add_meta_boxes($post_type)
     {
         if ($post_type !== 'boxzilla-box') {
-            return false;
+            return;
         }
 
         add_meta_box(
@@ -423,8 +419,6 @@ public function add_meta_boxes($post_type)
             'boxzilla-box',
             'side'
         );
-
-        return true;
     }
 
     /**
@@ -489,30 +483,28 @@ public function metabox_support(\WP_Post $post, $metabox)
      * Saves box options and rules
      *
      * @param int $box_id
-     *
-     * @return bool
+     * @param \WP_Post $post
      */
     public function save_box_options($box_id, $post)
     {
-
         // Only act on our own post type
         if ($post->post_type !== 'boxzilla-box') {
-            return false;
+            return;
         }
 
         // is this a revision save?
         if (wp_is_post_revision($box_id) || ( defined('DOING_AUTOSAVE') && DOING_AUTOSAVE )) {
-            return false;
+            return;
         }
 
         // can user edit this post?
         if (! current_user_can('edit_post', $box_id)) {
-            return false;
+            return;
         }
 
         // make sure options array is set
         if (! isset($_POST['boxzilla_box']) || ! is_array($_POST['boxzilla_box'])) {
-            return false;
+            return;
         }
 
         // get new options from $_POST
@@ -535,8 +527,6 @@ public function save_box_options($box_id, $post)
         }
 
         $this->flush_rules($box_id);
-
-        return true;
     }
 
     /**

src/admin/class-review-notice.php

@@ -34,36 +34,33 @@ public function dismiss()
         update_user_meta($user->ID, $this->meta_key_dismissed, 1);
     }
 
-    /**
-     * @return bool
-     */
     public function show()
     {
         $screen = get_current_screen();
         if (! $screen instanceof WP_Screen) {
-            return false;
+            return;
         }
 
         // on some boxzilla screen?
         if ($screen->post_type !== 'boxzilla-box') {
-            return false;
+            return;
         }
 
         // authorized?
         if (! current_user_can('edit_posts')) {
-            return false;
+            return;
         }
 
         // only show if 2 weeks have passed since first use.
         $two_weeks_in_seconds = ( 60 * 60 * 24 * 14 );
         if ($this->time_since_first_use() <= $two_weeks_in_seconds) {
-            return false;
+            return;
         }
 
         // only show if user did not dismiss before
         $user = wp_get_current_user();
         if (get_user_meta($user->ID, $this->meta_key_dismissed, true)) {
-            return false;
+            return;
         }
 
         echo '<div class="notice notice-info boxzilla-is-dismissible">';
@@ -74,7 +71,6 @@ public function show()
         echo '</p>';
         echo '<form method="POST"><button type="submit" class="notice-dismiss"><span class="screen-reader-text">', esc_html__('Dismiss this notice.', 'boxzilla'), '</span></button><input type="hidden" name="_boxzilla_admin_action" value="dismiss_review_notice"/></form>';
         echo '</div>';
-        return true;
     }
 
     /**

src/di/class-container.php

@@ -1,7 +1,7 @@
 <?php
 // phpcs:ignoreFile
 /*
- * This file is part of Pimple.
+ * This is a modified version of Pimple, a dependency injection container for PHP originally developed by Fabien Potencier.
  *
  * Copyright (c) 2009 Fabien Potencier
  *
@@ -253,22 +253,4 @@ public function extend( $id, $callable ) {
 	public function keys() {
 		return array_keys( $this->values );
 	}
-
-	/**
-	 * Registers a service provider.
-	 *
-	 * @param ServiceProviderInterface $provider A ServiceProviderInterface instance
-	 * @param array                    $values   An array of values that customizes the provider
-	 *
-	 * @return static
-	 */
-	public function register( ServiceProviderInterface $provider, array $values = array() ) {
-		$provider->register( $this );
-
-		foreach ( $values as $key => $value ) {
-			$this[ $key ] = $value;
-		}
-
-		return $this;
-	}
 }

src/licensing/class-license.php

@@ -109,8 +109,6 @@ public function reload()
 
     /**
      * Save the license in the database
-     *
-     * @return License
      */
     public function save()
     {