@@ -23,9 +23,8 @@ public function testExtractPageviewData(): void
2323 $ this ->assertEquals (extract_pageview_data (['p ' => '1 ' , 'r ' => 'not an url ' ]), []);
2424
2525 // complete and valid
26- foreach (
27- [
28- [['p ' => '1 ' ], ['p ' , null , 1 , 0 , 0 , '' ]],
26+ foreach ([
27+ [['p ' => '1 ' ], ['p ' , null , 1 , 1 , 1 , '' ]],
2928
3029 ] as [$ input , $ expected ]
3130 ) {
@@ -41,27 +40,20 @@ public function testExtractPageviewData(): void
4140
4241 public function testExtractEventData (): void
4342 {
44- // incomplete
43+ // incomplete
4544 $ this ->assertEquals (extract_event_data ([]), []);
4645 $ this ->assertEquals (extract_event_data (['e ' => 'Event ' ]), []);
4746 $ this ->assertEquals (extract_event_data (['p ' => 'Param ' ]), []);
48- $ this ->assertEquals (extract_event_data (['u ' => '1 ' ]), []);
4947 $ this ->assertEquals (extract_event_data (['v ' => '1 ' ]), []);
5048 $ this ->assertEquals (extract_event_data (['e ' => 'Event ' , 'v ' => '1 ' ]), []);
51- $ this ->assertEquals (extract_event_data (['e ' => 'Event ' , 'u ' => '1 ' ]), []);
5249 $ this ->assertEquals (extract_event_data (['p ' => 'Param ' , 'v ' => '1 ' ]), []);
53- $ this ->assertEquals (extract_event_data (['p ' => 'Param ' , 'u ' => '1 ' ]), []);
54- $ this ->assertEquals (extract_event_data (['e ' => 'Event ' , 'p ' => 'Param ' , 'u ' => '1 ' ]), []);
55- $ this ->assertEquals (extract_event_data (['e ' => 'Event ' , 'p ' => 'Param ' , 'v ' => '1 ' ]), []);
5650
57- // complete but invalid
58- $ this ->assertEquals (extract_event_data (['e ' => 'Event ' , 'p ' => 'Param ' , 'u ' => '1 ' , 'v ' => 'nan ' ]), []);
59- $ this ->assertEquals (extract_event_data (['e ' => 'Event ' , 'p ' => 'Param ' , 'u ' => 'nan ' , 'v ' => '100 ' ]), []);
60- $ this ->assertEquals (extract_event_data (['e ' => 'Event ' , 'p ' => 'Param ' , 'u ' => 'nan ' , 'v ' => 'nan ' ]), []);
61- $ this ->assertEquals (extract_event_data (['e ' => '' , 'p ' => 'Param ' , 'u ' => '1 ' , 'v ' => '100 ' ]), []);
51+ // complete but invalid
52+ $ this ->assertEquals (extract_event_data (['e ' => 'Event ' , 'p ' => 'Param ' , 'v ' => 'nan ' ]), []);
53+ $ this ->assertEquals (extract_event_data (['e ' => '' , 'p ' => 'Param ' , 'v ' => '100 ' ]), []);
6254
63- // complete and valid
64- $ actual = extract_event_data (['e ' => 'Event ' , 'p ' => 'Param ' , 'u ' => ' 1 ' , ' v ' => '100 ' ]);
55+ // complete and valid
56+ $ actual = extract_event_data (['e ' => 'Event ' , 'p ' => 'Param ' , 'v ' => '100 ' ]);
6557 $ expected = ['e ' , 'Event ' , 'Param ' , 1 , 100 ];
6658 $ this ->assertEquals ($ expected [0 ], $ actual [0 ]);
6759 $ this ->assertEquals ($ expected [1 ], $ actual [1 ]);
0 commit comments